merge queue: embarking devel (fd939ec) and #5891 together#5926
Closed
mergify[bot] wants to merge 4 commits into
Closed
merge queue: embarking devel (fd939ec) and #5891 together#5926mergify[bot] wants to merge 4 commits into
mergify[bot] wants to merge 4 commits into
Conversation
add ListListeners grpc query to fetch the current listener list for specific subsystem. added because auto-listener feature creates automatically listeners, and the listeners list is needed for the node-server. Signed-off-by: gadi-didi <gadi.didi@ibm.com>
add the option "networkMask" in SC. This
option is intoduced to replace the listener list entry
in the SC. with this param the admin does need to know
what are GWs IPs. just needs to provide the network mask
of the deployment. one way to get it, by run
`oc get network.config/cluster -o \
jsonpath='{.status.clusterNetwork[*].cidr}'`
then, assign the value in networkMask field,
and that's it.
Signed-off-by: gadi-didi <gadi.didi@ibm.com>
add the networkMask param into create subsystem call. Signed-off-by: gadi-didi <gadi.didi@ibm.com>
Collaborator
|
/test ci/centos/k8s-e2e-external-storage/1.32 |
Collaborator
|
/test ci/centos/k8s-e2e-external-storage/1.33 |
Collaborator
|
/test ci/centos/upgrade-tests-cephfs |
Collaborator
|
/test ci/centos/mini-e2e-helm/k8s-1.32 |
Collaborator
|
/test ci/centos/mini-e2e-helm/k8s-1.33 |
Collaborator
|
/test ci/centos/k8s-e2e-external-storage/1.34 |
Collaborator
|
/test ci/centos/mini-e2e/k8s-1.32 |
Collaborator
|
/test ci/centos/upgrade-tests-rbd |
Collaborator
|
/test ci/centos/mini-e2e/k8s-1.33 |
Collaborator
|
/test ci/centos/mini-e2e-helm/k8s-1.34 |
Collaborator
|
/test ci/centos/mini-e2e/k8s-1.34 |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Pull request #5891 which was ahead in the queue has been dequeued (for the following reason:
checks failed). ✨Branch devel (fd939ec) and #5891 are embarked together for merge.
This pull request has been created by Mergify to speculatively check the mergeability of #5891.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue
defaultfor merge:base~=^(release-.+)$label=ci/skip/e2estatus-success=ci/centos/mini-e2e/k8s-1.32status-success=ci/centos/mini-e2e/k8s-1.33status-success=ci/centos/k8s-e2e-external-storage/1.32status-success=ci/centos/k8s-e2e-external-storage/1.33status-success=ci/centos/k8s-e2e-external-storage/1.34status-success=ci/centos/mini-e2e-helm/k8s-1.32status-success=ci/centos/mini-e2e-helm/k8s-1.33status-success=ci/centos/mini-e2e-helm/k8s-1.34status-success=ci/centos/mini-e2e/k8s-1.34status-success=ci/centos/upgrade-tests-cephfsstatus-success=ci/centos/upgrade-tests-rbdstatus-success=codespellstatus-success=go-teststatus-success=golangci-lintstatus-success=lint-extrasstatus-success=mod-checkstatus-success=multi-arch-buildstatus-success=uncommitted-code-checkbase=release-v3.15label=ci/skip/e2estatus-success=ci/centos/k8s-e2e-external-storage/1.31status-success=ci/centos/mini-e2e-helm/k8s-1.31status-success=ci/centos/mini-e2e/k8s-1.31status-success=ci/centos/mini-e2e/k8s-1.32status-success=ci/centos/mini-e2e/k8s-1.33status-success=ci/centos/k8s-e2e-external-storage/1.32status-success=ci/centos/k8s-e2e-external-storage/1.33status-success=ci/centos/mini-e2e-helm/k8s-1.32status-success=ci/centos/mini-e2e-helm/k8s-1.33status-success=ci/centos/upgrade-tests-cephfsstatus-success=ci/centos/upgrade-tests-rbdstatus-success=codespellstatus-success=go-teststatus-success=golangci-lintstatus-success=lint-extrasstatus-success=mod-checkstatus-success=multi-arch-buildstatus-success=uncommitted-code-checklabel=ci/skip/e2estatus-success=ci/centos/mini-e2e/k8s-1.32status-success=ci/centos/mini-e2e/k8s-1.33status-success=ci/centos/k8s-e2e-external-storage/1.32status-success=ci/centos/k8s-e2e-external-storage/1.33status-success=ci/centos/k8s-e2e-external-storage/1.34status-success=ci/centos/mini-e2e-helm/k8s-1.32status-success=ci/centos/mini-e2e-helm/k8s-1.33status-success=ci/centos/mini-e2e-helm/k8s-1.34status-success=ci/centos/mini-e2e/k8s-1.34status-success=ci/centos/upgrade-tests-cephfsstatus-success=ci/centos/upgrade-tests-rbdbase=develstatus-success=codespellstatus-success=go-teststatus-success=golangci-lintstatus-success=lint-extrasstatus-success=mod-checkstatus-success=multi-arch-buildstatus-success=uncommitted-code-checkbase=ci/centosstatus-success=ci/centos/jjb-validatestatus-success=ci/centos/job-validation#approved-reviews-by >= 2[🛡 GitHub branch protection]#changes-requested-reviews-by = 0[🛡 GitHub branch protection]Required conditions to stay in the queue:
#approved-reviews-by >= 2[🛡 GitHub branch protection]#changes-requested-reviews-by = 0[🛡 GitHub branch protection]