Skip to content

rbd: ControllerModifyVolume should report an error when setting QoS on non rbd-nbd volumes #6186

@nixpanic

Description

@nixpanic

actually, there is one thing that probably should be added here. A check if the volume uses rbd-nbd is crucial. If it isn't the case, setting QoS parameters will not have any effect.

A gRPC INVALID_ARGUMENT error should be returned for non rbd-nbd volumes

Originally posted by @nixpanic in #6160


This isn't trivial. There is rbdVol.Mounter that would be set to rbd-nbd, but genVolFromVolIDWithMigration returns an empty rbdVol.Mounter. The logic within genVolFromVolIDWithMigration does not assign a value to rbdVol.Mounter.

Metadata

Metadata

Assignees

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions