Skip to content

Remove metrics skipping on Kubernetes 1.34 #5635

@nixpanic

Description

@nixpanic

Remove this function once kubernetes/kubernetes/#133847 has been addressed and a release is available (Kubernetes 1.34.2?).

ceph-csi/e2e/utils.go

Lines 1690 to 1705 in 3053eb5

// k8sBrokenMetrics detects if Kubernetes 1.34 is used, this version has broken
// kube_volume_stats_* metrics:
// https://github.com/kubernetes/kubernetes/issues/133847
func k8sBrokenMetrics(c kubernetes.Interface) bool {
if brokenMetrics == nil {
broken := true
functional := true
if k8sVersionGreaterEquals(c, 1, 34) && !k8sVersionGreaterEquals(c, 1, 35) {
brokenMetrics = &broken
} else {
brokenMetrics = &functional
}
}
return *brokenMetrics
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    dependency/k8sdepends on Kubernetes featuresgood first issueGood for newcomerskeepaliveThis label can be used to disable stale bot activiity in the repo

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions