ceph-dev-pipeline/build/Jenkinsfile: fix crimson-debug#2494
Merged
Conversation
When ceph-dev-pipeline was introduced, crimson-debug cmake flag was left out. The corresponding ceph_build_args_from_flavor from scrips/build_utils.sh is defined correctly. Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Contributor
Author
|
Can you please help me understand better the new build pipeline:
Thank you! |
Member
|
build_utils.sh has a lot of stuff in it (@zmc has been breaking it up but it's still quite the catchall). The intent was to use relevant pieces in ceph-dev-pipeline, or recode them where applicable. This one got missed. |
zmc
approved these changes
Nov 10, 2025
Member
zmc
left a comment
There was a problem hiding this comment.
Thanks for this, and sorry that got lost as we switched to ceph-dev-pipeline right around the time of the crimson flavor split
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When ceph-dev-pipeline was introduced, crimson-debug cmake flag was left out. The corresponding ceph_build_args_from_flavor from scrips/build_utils.sh is defined correctly.