Conversation
jdurgin
approved these changes
Feb 24, 2021
Member
jdurgin
left a comment
There was a problem hiding this comment.
we're no longer using this flavor on all current branches - nautilus/octopus/pacific/master
Member
|
refs: ceph/ceph#39561 |
We no longer need notmcalloc packages. Valgrind works now. See ceph/ceph#39561 Signed-off-by: David Galloway <dgallowa@redhat.com>
ac30fce to
c95d1cc
Compare
liewegas
reviewed
Feb 24, 2021
| CEPH_EXTRA_CMAKE_ARGS="$CEPH_EXTRA_CMAKE_ARGS -DALLOCATOR=tcmalloc" | ||
| fi | ||
| CEPH_EXTRA_RPMBUILD_ARGS="--with tcmalloc" | ||
| CEPH_EXTRA_CMAKE_ARGS="$CEPH_EXTRA_CMAKE_ARGS -DALLOCATOR=tcmalloc" |
Member
There was a problem hiding this comment.
this is probably unnecessary.. mostly it means that if the distro or build-requires don't have tcmalloc installed then the build will fail installed of falling back to libc.
liewegas
approved these changes
Feb 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We no longer need notmcalloc packages. Vagrant works now.
Signed-off-by: David Galloway dgallowa@redhat.com