client: fix wrong lock logic of ll_read_block() method#9572
Merged
jcsp merged 1 commit intoceph:masterfrom Jun 14, 2016
Merged
Conversation
Contributor
|
This looks correct, but perhaps when cleaning this up you could simplify it further by replacing the C_SafeCond with a C_SaferCond, so that the done/cond vars are no longer needed? Currently we use a mixture, but when doing cleanup it is nice to replace things with SaferCond where possible |
528dfca to
451c32b
Compare
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Member
Author
|
Done and label this one as "needs-qa". |
Contributor
|
Reviewed-by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xie xingguo xie.xingguo@zte.com.cn