Conversation
fd3709f to
f99e923
Compare
| @@ -0,0 +1,74 @@ | |||
| // -*- mode:C++; tab-width:8; c-basic-offset:2; indent-tabs-mode:t -*- | |||
There was a problem hiding this comment.
Can this just be combined with the current "ObjectMap.cc" file to keep all object map operations together?
There was a problem hiding this comment.
Well, right now there is a 1:1 correspondence between tool actions and the source files that implement them (cf. ObjectMapUpdateRequest.cc). ObjectMap.cc contains the library tooling and this seemed like a user-level operation like the others in operations/. I'll change it if you want, though.
There was a problem hiding this comment.
This is for the cli -- most of the related commands are grouped into the same file.
There was a problem hiding this comment.
I'd still like to see all the object map commands handles within "src/tools/rbd/action/ObjectMap.cc"
There was a problem hiding this comment.
I misconstrued this note to refer to librbd/operation instead of tools/rbd/action. Sorry about that; I'll merge the files.
f99e923 to
9011d53
Compare
9e995f0 to
94a5186
Compare
57b67f9 to
09d714a
Compare
|
@fullerdj unittest_librbd is failing on the TestLibRBD.CheckObjectMap test case. |
|
Where/how do you see that? It passes on my test setup, maybe I’m missing something.
|
|
@fullerdj I just re-merged and re-built it and still see the failure:
|
09d714a to
85c1e17
Compare
|
This should be fixed now. |
|
Now this fails on "RBD_FEATURES=109 ./unittest_librbd"
|
Add a CLI option to verify the object map for an unmapped image for debugging purposes. Syntax: rbd object-map check <image-name> This operation is not supported on currently mapped images. Any inconsistencies that could affect the correctness of future operations are noted and the object map (and fast diff state, if enabled) is invalidated. Inconsistencies that do not affect correctness will be emitted at debug level 1 or higher. Consolidate code path with object-map rebuild and remove newly unused code. Fixes: http://tracker.ceph.com/issues/14867 Signed-off-by: Douglas Fuller <dfuller@redhat.com>
85c1e17 to
a100f02
Compare
|
This should actually be fixed now. |
|
lgtm |
Add a CLI option to verify the object map for an unmapped image
for debugging purposes. Syntax:
rbd object-map check
This operation is not supported on currently mapped images.
Any inconsistencies that could affect the correctness of future
operations are noted and the object map (and fast diff state, if
enabled) is invalidated. Inconsistencies that do not affect
correctness will be emitted at debug level 1 or higher.
Consolidate code path with object-map rebuild and remove newly
unused code.
Fixes: http://tracker.ceph.com/issues/14867
Signed-off-by: Douglas Fuller dfuller@redhat.com