Skip to content

test/rgw/notification: remove depracated dependencies#67387

Merged
yuvalif merged 6 commits intoceph:mainfrom
yuvalif:wi-yuval-bucket-notifications
Feb 25, 2026
Merged

test/rgw/notification: remove depracated dependencies#67387
yuvalif merged 6 commits intoceph:mainfrom
yuvalif:wi-yuval-bucket-notifications

Conversation

@yuvalif
Copy link
Contributor

@yuvalif yuvalif commented Feb 18, 2026 •
edited
Loading

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

You must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.

@yuvalif yuvalif changed the title test/rgw: remove depracated boto dependency test/rgw/notification: remove depracated boto dependency Feb 18, 2026
@yuvalif yuvalif mentioned this pull request Feb 18, 2026
Closed
14 tasks
@yuvalif yuvalif force-pushed the wi-yuval-bucket-notifications branch from 53e8de4 to 8380f3e Compare February 18, 2026 13:56
@yuvalif yuvalif force-pushed the wi-yuval-bucket-notifications branch from 5b5abe6 to d577c3e Compare February 19, 2026 17:26
@thuvh
Copy link
Contributor

thuvh commented Feb 20, 2026

look good to me @yuvalif

@yuvalif yuvalif force-pushed the wi-yuval-bucket-notifications branch from d577c3e to 97b4270 Compare February 20, 2026 16:08
@yuvalif yuvalif changed the title test/rgw/notification: remove depracated boto dependency test/rgw/notification: remove depracated dependencies Feb 20, 2026
@github-actions
Copy link

github-actions bot commented Feb 20, 2026

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@yuvalif
Copy link
Contributor Author

yuvalif commented Feb 20, 2026

all tests are passing (tests failed with valgrind issue): https://pulpito.ceph.com/yuvalif-2026-02-20_16:10:34-rgw:notifications-wip-yuval-bucket-notifications-distro-default-trial/

@yuvalif yuvalif mentioned this pull request Feb 20, 2026
Merged
@yuvalif
Copy link
Contributor Author

yuvalif commented Feb 22, 2026

e.g. run that failed due to netstat: https://qa-proxy.ceph.com/teuthology/yuvalif-2026-02-22_18:47:22-rgw:notifications-main-distro-default-trial/63927/teuthology.log

cbodley
cbodley reviewed Feb 23, 2026
View reviewed changes
src/test/rgw/bucket_notification/api.py


# Boto3 compatibility wrapper classes to minimize code changes
class S3Key:
Copy link
Contributor

@cbodley cbodley Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm skeptical that you'll want this compatibility layer in the long term, but at least new tests can be written directly against boto3

Copy link
Contributor Author

@yuvalif yuvalif Feb 23, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was mainly to keep the changes minimal, and make the review easier :-)
but i can change that to native boto3.

btw, we already had these unnecessary classes for topics and notifications in the original test. so, maybe I'll remove them all

Copy link
Contributor

@cbodley cbodley Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

up to you whether you want to do that now or later. i wasn't planning to review the test changes in detail, i'm happy just to see it pass in teuthology

yuvalif and others added 6 commits February 23, 2026 17:47
@yuvalif
test/rgw/notifications: cleanup of tests
8f97065 
* remove dead code
* remove unnecessary text from test names used when we supported
  "pubsub" (pull mode)

Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
@yuvalif
test/rgw: remove depracated boto dependency
8e9c771 
Fixes: https://tracker.ceph.com/issues/73663

Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
Co-authored-by: Bob-Shell <bob-shell@ai-assistant>
@yuvalif
test/rgw/notifications: fixes needed to run the tests in a multisite …
8935c1f 
…environment

the main issue was that a system user would get a JSON reply when
creating a bucket. the boto3 client is failing when this is happening.
so, the solution is to use a non-system user in the tests

Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
@yuvalif @claude
test/rgw/notifications: migrate from nose to pytest
0d8a70b 
Fixes: https://tracker.ceph.com/issues/74573

Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
Co-Authored-By: Claude <noreply@anthropic.com>
@yuvalif
test/rgw/notification: do not use netstat in the code
5e204e1 
* net-tools are deprecated in fedora and ubuntu
* using netstat -p (used to verify that the http server is listening on
  a port) requires root privilages, which may fail in some tests environments

Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
@yuvalif
test/rgw/notifications: increase the max number of boto client connec…
7d90114 
…tions

this is to avoid this warning:
WARNING  urllib3.connectionpool:connectionpool.py:305 Connection pool is full, discarding connection: localhost

Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
@yuvalif yuvalif force-pushed the wi-yuval-bucket-notifications branch from 97b4270 to 7d90114 Compare February 23, 2026 17:49
@yuvalif
Copy link
Contributor Author

yuvalif commented Feb 23, 2026

jenkins test make check arm64

1 similar comment
@yuvalif
Copy link
Contributor Author

yuvalif commented Feb 24, 2026

jenkins test make check arm64

@yuvalif yuvalif merged commit e851e5a into ceph:main Feb 25, 2026
12 of 13 checks passed
@github-actions
Copy link

github-actions bot commented Feb 25, 2026 

        This is an automated message by src/script/redmine-upkeep.py.

        I found one or more `Fixes:` tags in the commit messages in

        `git log e851e5ab38b68d841f016dac938a4c824bd156be^..e851e5ab38b68d841f016dac938a4c824bd156be`

        The referenced tickets are:

        * https://tracker.ceph.com/issues/74573

  • https://tracker.ceph.com/issues/73663

          Those tickets do not reference this merged Pull Request. If this Pull Request merge resolves any of those tickets, please update the "Pull Request ID" field on each ticket. A future run of this script will appropriately update them.


      Update Log: https://github.com/ceph/ceph/actions/runs/22389370009

@cbodley
Copy link
Contributor

cbodley commented Feb 25, 2026

woo, thanks @yuvalif and @thuvh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbodley cbodley cbodley approved these changes

@adamemerson adamemerson Awaiting requested review from adamemerson

Assignees

No one assigned

Labels

documentation rgw tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yuvalif @thuvh @cbodley @adamemerson