qa: Add retry logic to remove most sleeps in mirroring tests#67305
Merged
qa: Add retry logic to remove most sleeps in mirroring tests#67305
Conversation
Contributor
Author
|
Schedueled teuthology job with main branch: |
Contributor
Author
The test case The failure was an existing timing issue and nothing related to this PR. Check the analysis below. The mirror daemon found the state to be failed at The test case I will increase the max_retry seconds to 100 but it should well complete before that. |
Contributor
Author
Addressed with b5d02cd |
Contributor
Author
|
New scheduled Teuthology run - https://pulpito.ceph.com/khiremat-2026-02-12_08:18:51-fs-main-distro-default-trial/ |
vshankar
reviewed
Feb 12, 2026
Contributor
Author
|
Latest scheduled teuthology run with safe_while - https://pulpito.ceph.com/khiremat-2026-02-12_14:18:34-fs-main-distro-default-trial/ |
Contributor
Author
Two failures -
@vshankar should we modify the data set or remove this assert for now ?
I think this because of admin socket init failed ? |
The mirroring tests contain lot of sleeps adding it up to ~1hr. This patch adds a retry logic and removes most of them. This is cleaner and saves considerable time in test time for mirroring. Fixes: https://tracker.ceph.com/issues/74878 Signed-off-by: Kotresh HR <khiremat@redhat.com>
Fixes: https://tracker.ceph.com/issues/74896 Signed-off-by: Kotresh HR <khiremat@redhat.com>
Contributor
Author
I have reduced the git reset head count. Hopefully this should fix it.
|
Contributor
Author
|
Latest QA Run (test_cephfs_mirror_incremental_sync fix - HEAD~{5..10}) - https://pulpito.ceph.com/khiremat-2026-02-12_18:18:49-fs-main-distro-default-trial/ |
Contributor
For small file sizes, using blockdiff will certainly not result in better sync times, so the sync time will be closer to full transfer. IMO, lets remove the assert. |
Contributor
Nice 👍 |
Contributor
Author
With the change of |
Contributor
Yeh. |
vshankar
approved these changes
Feb 16, 2026
|
This is an automated message by src/script/redmine-upkeep.py. I have resolved the following tracker ticket due to the merge of this PR: No backports are pending for the ticket. If this is incorrect, please update the tracker Update Log: https://github.com/ceph/ceph/actions/runs/22051934083 |
|
This is an automated message by src/script/redmine-upkeep.py. I have resolved the following tracker ticket due to the merge of this PR: No backports are pending for the ticket. If this is incorrect, please update the tracker Update Log: https://github.com/ceph/ceph/actions/runs/22051934083 |
This was referenced Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mirroring tests contain lot of sleeps adding it up to ~1hr.
This patch adds a retry logic and removes most of them.
This is cleaner and saves considerable time in test time for mirroring.
Fixes: https://tracker.ceph.com/issues/74878
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job DefinitionYou must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.