rgw/configstore: don't reinitialize the rados client in RadosRealmWatcher#67287
rgw/configstore: don't reinitialize the rados client in RadosRealmWatcher#67287
Conversation
|
@cbodley , I have changed the With these changes valgrind reports: |
The RadosRealmWatcher::watch_start() function incorrectly reinitialized a rados client that had already been initialized during the creation of the ConfigStore. This caused the original Objecter to be lost, which was subsequently reported as a memory leak by Valgrind. Signed-off-by: Nithya Balachandran <nithya.balachandran@ibm.com>
dc4e3ad to
c83a31e
Compare
cbodley
left a comment
There was a problem hiding this comment.
looks good, thanks 👍 the rgw/multisite qa suite should catch any regressions here
|
jenkins test make check |
|
jenkins test windows |
|
jenkins test make check arm64 |
|
jenkins test make check |
|
jenkins test make check arm64 |
|
Teuthology results:
Waiting on results.... |
1 similar comment
|
Teuthology results:
Waiting on results.... |
|
just FYI, planning to discuss that tomo on rgw call. |
|
jenkins test make check |
RadosRealmWatcher::watch_start() was reusing and re-initing a rados client which had been inited when creating the ConfigStore. This led to the original Objecter being lost and valgrind reporting a leak.
Fixes: https://tracker.ceph.com/issues/71390
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job DefinitionYou must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.