rgw/test: add more output in boto3 versioning testing#67190
Merged
rgw/test: add more output in boto3 versioning testing#67190
Conversation
Member
Author
|
@jzhu116-bloomberg : would you mind reviewing this since you were the last to touch this section of code? |
cc7c9ee to
e203f0a
Compare
Saw a spurious error in this test and figured it'd be helpful if more information was logged in case another spurious error occcurs. Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
e203f0a to
0ae8f31
Compare
jzhu116-bloomberg
approved these changes
Feb 5, 2026
Member
Author
|
jenkins test api |
Member
Author
|
Teuthology results, no regressions: |
cbodley
reviewed
Feb 6, 2026
| log.info(f"json_out has length of { len(json_out) }") | ||
| idx_list = list(map(lambda v: v['idx'], json_out)) | ||
| log.info(f"json_out has idx's of { idx_list }") | ||
| assert(len(json_out) == 4, |
Contributor
There was a problem hiding this comment.
workunits/rgw/test_rgw_versioning.py:78: error: Assertion is always true, perhaps remove parentheses?
this is causing run-tox-qa failures in make check, tracked in https://tracker.ceph.com/issues/74809
Member
Author
|
Fix has been merged: #67247 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saw a spurious error in this test (the assert) and figured it'd be helpful if more information were logged in case another error occurs.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job DefinitionYou must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.