qa/radosgw_admin: replace boto2 with boto3#67095
Conversation
|
successful radosgw_admin task in https://pulpito.ceph.com/cbodley-2026-02-12_21:25:01-rgw:singleton-main-distro-default-trial/ fails just after on radosgw_admin_rest |
|
this is mostly working, but query params are now getting url-encoded for sigv4 auth but rgw doesn't url-decode this fails with NoSuchSubUser because the server sees this as |
they were comparing the output of 'radosgw-admin policy' with the xml output of boto2's get_acl() function, but boto3 doesn't expose the xml response 'radosgw-admin policy' is just dumping the same output as our s3 GetObjectAcl api, so test coverage from s3-tests is sufficient for this Signed-off-by: Casey Bodley <cbodley@redhat.com>
5ada475 to
741c42f
Compare
the requestlog queue is only used for debugging, and relied on boto2 hooks that aren't worth rewriting in boto3 Signed-off-by: Casey Bodley <cbodley@redhat.com>
Fixes: https://tracker.ceph.com/issues/74591 Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
replace the boto2 connection with a boto3 client for bucket/object creation aws credentials are passed into rgwadmin_rest() as an instance of botocore.auth.SigV4Auth build_admin_request() now returns an instance of botocore.awsrequest.AWSRequest instead of boto.connection.AWSAuthConnection Fixes: https://tracker.ceph.com/issues/74591 Signed-off-by: Casey Bodley <cbodley@redhat.com>
| bucket.delete() | ||
| rl.log_and_clear("delete_bucket", bucket_name, user1) | ||
|
|
||
| # TESTCASE 'policy', 'bucket', 'policy', 'get bucket policy', 'returns S3 policy' |
There was a problem hiding this comment.
where is this testcase in the new code?
There was a problem hiding this comment.
removed with commit message:
qa/radosgw_admin: remove acl test cases
they were comparing the output of 'radosgw-admin policy' with the xml output of boto2's get_acl() function, but boto3 doesn't expose the xml response
'radosgw-admin policy' is just dumping the same output as our s3 GetObjectAcl api, so test coverage from s3-tests is sufficient for this
|
seeing run-tox-qa fail with unrelated error:
raised #67486 for that |
|
jenkins test make check |
|
jenkins test make check arm64 |
|
jenkins test make check |
|
jenkins test make check arm64 |
|
jenkins test make check |
|
jenkins test make check arm64 |
|
|
jenkins test make check |
|
|
jenkins test make check arm64 |
|
|
jenkins test make check arm64 |
|
|
jenkins test make check arm64 |
Fixes: https://tracker.ceph.com/issues/74591
TODO:
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job DefinitionYou must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.