tentacle: scripts/build/ceph.spec.in: fix rhel version checks#66865
Merged
batrick merged 1 commit intoceph:tentaclefrom Feb 10, 2026
Merged
tentacle: scripts/build/ceph.spec.in: fix rhel version checks#66865batrick merged 1 commit intoceph:tentaclefrom
batrick merged 1 commit intoceph:tentaclefrom
Conversation
Fixing multiple instances in this file where
the RHEL version is checked - without properly
ensuring that the OS is indeed RHEL.
0%{?rhel} is only defined on RHEL systems, and
is '0' otherwise. That resulted, for example, in
Fedora 43 having 'gts_version' incorrectly
set to '13'.
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
(cherry picked from commit e042983)
idryomov
approved these changes
Jan 9, 2026
Contributor
Author
|
jenkins test make check |
Contributor
Author
|
jenkins test api |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing multiple instances in this file where
the RHEL version is checked - without properly
ensuring that the OS is indeed RHEL.
0%{?rhel} is only defined on RHEL systems, and
is '0' otherwise. That resulted, for example, in
Fedora 43 having 'gts_version' incorrectly
set to '13'.
Backport of #66772
Fixes: https://tracker.ceph.com/issues/74369
Original tracker: https://tracker.ceph.com/issues/74368
(cherry picked from commit e042983)