Skip to content

qa/cephadm: add default container image name base#66847

Merged
yuriw merged 1 commit intoceph:mainfrom
adk3798:cephadm-teuth-assume-default-image-base
Jan 21, 2026
Merged

qa/cephadm: add default container image name base#66847
yuriw merged 1 commit intoceph:mainfrom
adk3798:cephadm-teuth-assume-default-image-base

Conversation

@adk3798
Copy link
Contributor

@adk3798 adk3798 commented Jan 8, 2026

Recent runs in the new lab for cephadm jobs are hitting

2026-01-06T00:47:00.247 ERROR:teuthology.run_tasks:Saw exception from tasks.
Traceback (most recent call last):
  File "/home/teuthworker/src/git.ceph.com_teuthology_8707f5d0ca0e547efc56a3734c7aa4a4cf45b1f4/teuthology/run_tasks.py", line 112, in run_tasks
    manager.__enter__()
  File "/usr/lib/python3.12/contextlib.py", line 137, in __enter__
    return next(self.gen)
           ^^^^^^^^^^^^^^
  File "/home/teuthworker/src/github.com_ceph_ceph-c_73712ccf0d7b99648a0c0d2ebf766adc13587a45/qa/tasks/cephadm.py", line 1961, in task
    raise Exception("Configuration error occurred. "
Exception: Configuration error occurred. The 'image' value is undefined for 'cephadm' task. Please provide...

but it appears the build is still pushing images to quay.ceph.io/ceph-ci/ceph: which is the image we would be looking for. The bit that raises an exception if this isn't set is quite old, and I'm unsure if we still need it or it's safe to just assume this naming scheme can be used if an explicit image is passed, but this seems worth a try

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

You must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.

Recent runs in the new lab for cephadm jobs are hitting

```
2026-01-06T00:47:00.247 ERROR:teuthology.run_tasks:Saw exception from tasks.
Traceback (most recent call last):
  File "/home/teuthworker/src/git.ceph.com_teuthology_8707f5d0ca0e547efc56a3734c7aa4a4cf45b1f4/teuthology/run_tasks.py", line 112, in run_tasks
    manager.__enter__()
  File "/usr/lib/python3.12/contextlib.py", line 137, in __enter__
    return next(self.gen)
           ^^^^^^^^^^^^^^
  File "/home/teuthworker/src/github.com_ceph_ceph-c_73712ccf0d7b99648a0c0d2ebf766adc13587a45/qa/tasks/cephadm.py", line 1961, in task
    raise Exception("Configuration error occurred. "
Exception: Configuration error occurred. The 'image' value is undefined for 'cephadm' task. Please provide...
```

but it appears the build is still pushing images to quay.ceph.io/ceph-ci/ceph:<sha1>
which is the image we would be looking for. The bit that raises an exception if
this isn't set is quite old, and I'm unsure if we still need it or it's safe
to just assume this naming scheme can be used if an explicit image is
passed, but this seems worth a try

Signed-off-by: Adam King <adking@redhat.com>
@phlogistonjohn
Copy link
Contributor

phlogistonjohn commented Jan 9, 2026

Reading the description of this PR makes me wonder if some configuration from the teuthology.yaml didn't get brought over with the lab move?

For example in my "local teuthology" I have:

defaults:
  cephadm:
    containers:
      image: quay.ceph.io/ceph-ci/ceph

which seems like I must have put in to satisfy this requirement. IOW maybe the code should be left alone and the config updated?

@ljflores
Copy link
Member

@adk3798 can you add this ticket to your commit? https://tracker.ceph.com/issues/74477
I made this so we can track the backports to Squid and Tentacle.

@yuriw yuriw merged commit 9e79538 into ceph:main Jan 21, 2026
13 of 15 checks passed
@djgalloway
Copy link
Contributor

djgalloway commented Jan 21, 2026

Reading the description of this PR makes me wonder if some configuration from the teuthology.yaml didn't get brought over with the lab move?

For example in my "local teuthology" I have:

defaults:
  cephadm:
    containers:
      image: quay.ceph.io/ceph-ci/ceph

which seems like I must have put in to satisfy this requirement. IOW maybe the code should be left alone and the config updated?

This is what happened and /etc/teuthology.yaml on soko04 has been modified as of a few minutes ago.

@djgalloway
Copy link
Contributor

#67054

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants