Skip to content

PeeringState::needs_recovery(): log first missing item#66606

Merged
shraddhaag merged 1 commit intoceph:mainfrom
shraddhaag:add-logs
Feb 13, 2026
Merged

PeeringState::needs_recovery(): log first missing item#66606
shraddhaag merged 1 commit intoceph:mainfrom
shraddhaag:add-logs

Conversation

@shraddhaag
Copy link
Contributor

@shraddhaag shraddhaag commented Dec 11, 2025

This PR logs the first missing item if recovery is not completed successfully.

The logs are added to aid deubgging: https://tracker.ceph.com/issues/70501.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

You must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.

@github-actions github-actions bot added the core label Dec 11, 2025
@shraddhaag
Copy link
Contributor Author

shraddhaag commented Dec 11, 2025

Status: Awaiting Shaman build (ref: https://shaman.ceph.com/builds/ceph/add-logs/fd3aac57157c3b184b9728f6d2402fb31e55d583/) and QA test.

@shraddhaag
Copy link
Contributor Author

jenkins test make check

@shraddhaag
Copy link
Contributor Author

jenkins test make check arm64

@shraddhaag
Copy link
Contributor Author

jenkins test api

@shraddhaag
Copy link
Contributor Author

jenkins test make check arm64

Signed-off-by: Shraddha Agrawal <shraddha.agrawal000@gmail.com>
@shraddhaag
Copy link
Contributor Author

shraddhaag commented Feb 12, 2026

In https://qa-proxy.ceph.com/teuthology/shraddhaag-2026-02-09_14:34:53-crimson-rados-main-distro-debug-trial/41478/, successfully confirmed that the log line is emitted in the following manner:

DEBUG 2026-02-12 10:55:03,927 [shard 2:main] osd -  pg_epoch 119 pg[4.d( v 119'1741 (118'1737,119'1741] local-lis/les=111/112 n=427 ec=90/90 lis/c=111/90 les/c/f=112/91/0 sis=111) [1,2,0]/[1,2] backfill=[0] r=0 lpr=111 pi=[90,111)/2 pct=119'1740 lua=109'1686 crt=119'1741 lcod 119'1739 mlcod 119'1739 active+undersized+remapped PeeringState::needs_recovery osd.0 has 1 missing, first missing oid=4:bff06d6e:::benchmark_data_trial005_29432_object9806:head

The interesting bit is at the end, highlighting it below:

osd.0 has 1 missing, first missing oid=4:bff06d6e:::benchmark_data_trial005_29432_object9806:head

This exact log line can be found in osd.1 logs.

@shraddhaag shraddhaag requested a review from Matan-B February 12, 2026 14:21
@shraddhaag shraddhaag marked this pull request as ready for review February 12, 2026 14:21
@shraddhaag
Copy link
Contributor Author

jenkins test windows

@amathuria amathuria self-requested a review February 13, 2026 04:45
@shraddhaag shraddhaag merged commit f050f6f into ceph:main Feb 13, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants