debian,ceph.spec: fix ceph-osd upgrade conflicts by Matan-B · Pull Request #66568 · ceph/ceph

Matan-B · 2025-12-09T09:55:43Z

With #65782 merged, upgrading ceph-osd would need to replace the previous ceph-osd existing on the machine. Otherwise, we won't be able to symlink the newly installed package:

2025-12-05T21:09:20.472 INFO:teuthology.orchestra.run.smithi077.stdout:
Installing       : ceph-osd-classic-2:20.3.0-4434.g8611241d.el9.x86_6
24/87
2025-12-05T21:09:20.478 INFO:teuthology.orchestra.run.smithi077.stdout:
Running scriptlet: ceph-osd-classic-2:20.3.0-4434.g8611241d.el9.x86_6
24/87
2025-12-05T21:09:20.479
INFO:teuthology.orchestra.run.smithi077.stdout:failed to link
/usr/bin/ceph-osd -> /etc/alternatives/ceph-osd: /usr/bin/ceph-osd
exists and it is not a symlink

See: #66341 (comment)

Contribution Guidelines

To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

Tracker (select at least one)
- References tracker ticket
- Very recent bug; references commit where it was introduced
- New feature (ticket optional)
- Doc update (no ticket needed)
- Code cleanup (no ticket needed)
Component impact
- Affects Dashboard, opened tracker ticket
- Affects Orchestrator, opened tracker ticket
- No impact that needs to be tracked
Documentation (select at least one)
- Updates relevant documentation
- No doc update is appropriate
Tests (select at least one)
- Includes unit test(s)
- Includes integration test(s)
- Includes bug reproducer
- No tests

Show available Jenkins commands

jenkins test classic perf Jenkins Job | Jenkins Job Definition
jenkins test crimson perf Jenkins Job | Jenkins Job Definition
jenkins test signed Jenkins Job | Jenkins Job Definition
jenkins test make check Jenkins Job | Jenkins Job Definition
jenkins test make check arm64 Jenkins Job | Jenkins Job Definition
jenkins test submodules Jenkins Job | Jenkins Job Definition
jenkins test dashboard Jenkins Job | Jenkins Job Definition
jenkins test dashboard cephadm Jenkins Job | Jenkins Job Definition
jenkins test api Jenkins Job | Jenkins Job Definition
jenkins test docs ReadTheDocs | Github Workflow Definition
jenkins test ceph-volume all Jenkins Jobs | Jenkins Jobs Definition
jenkins test windows Jenkins Job | Jenkins Job Definition
jenkins test rook e2e Jenkins Job | Jenkins Job Definition

You must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.

tchaikov · 2025-12-09T10:35:16Z

debian/control

         ${misc:Depends},
         ${shlibs:Depends},
+Conflicts: ceph-osd (<< 20.3)
+Replaces:  ceph-osd (<< 20.3)


instead of making ceph-osd conflict with ceph-osd, we might want to make ceph-osd-classic and ceph-osd-crimson conflict with ceph-osd (<< 20.3). because ceph-osd cannot coexist with another version of ceph-osd, so they inherently conflicts with each other. but in the failure, it was ceph-osd-classic which tried to create a symbolic link to /usr/bin/ceph-osd, which was a file provided by ceph-osd (<< 20.3).

Makes sense, thanks. Updating

Matan-B · 2025-12-09T10:55:27Z

https://shaman.ceph.com/builds/ceph/wip-matanb-crimson-obselte-v2

cbodley · 2025-12-09T16:28:55Z

thank you!

https://shaman.ceph.com/builds/ceph/wip-matanb-crimson-obselte-v2

it looks like builds are failing while quay.ceph.io is being migrated

tchaikov

lgtm

debian/control

cbodley · 2025-12-10T16:10:59Z

it looks like builds are failing while quay.ceph.io is being migrated

fresh builds in https://shaman.ceph.com/builds/ceph/wip-matanb-crimson-obselte/, i'll run the rgw/upgrade suite to verify

cbodley · 2025-12-10T16:54:20Z

fresh builds in https://shaman.ceph.com/builds/ceph/wip-matanb-crimson-obselte/, i'll run the rgw/upgrade suite to verify

from https://qa-proxy.ceph.com/teuthology/cbodley-2025-12-10_16:12:38-rgw:upgrade-wip-matanb-crimson-obselte-distro-default-smithi/8649442/teuthology.log,

   Installing       : ceph-osd-crimson-2:20.3.0-4335.ga39cb79c.el9.x86_6   20/85
  Running scriptlet: ceph-osd-crimson-2:20.3.0-4335.ga39cb79c.el9.x86_6   20/85
failed to link /usr/bin/ceph-osd -> /etc/alternatives/ceph-osd: /usr/bin/ceph-osd exists and it is not a symlink

  Upgrading        : ceph-volume-2:20.3.0-4335.ga39cb79c.el9.noarch       21/85
  Running scriptlet: ceph-volume-2:20.3.0-4335.ga39cb79c.el9.noarch       21/85
  Upgrading        : ceph-osd-2:20.3.0-4335.ga39cb79c.el9.x86_64          22/85
  Running scriptlet: ceph-osd-2:20.3.0-4335.ga39cb79c.el9.x86_64          22/85
  Installing       : ceph-osd-classic-2:20.3.0-4335.ga39cb79c.el9.x86_6   23/85
  Running scriptlet: ceph-osd-classic-2:20.3.0-4335.ga39cb79c.el9.x86_6   23/85
failed to link /usr/bin/ceph-osd -> /etc/alternatives/ceph-osd: /usr/bin/ceph-osd exists and it is not a symlink

tchaikov · 2025-12-11T08:10:21Z

@cbodley Thanks for testing.

@Matan-B I realized that the right fix is to use

    fi
    %endif

-  %post osd-classic
+  %posttrans osd-classic
   %{_sbindir}/update-alternatives --install %{_bindir}/ceph-osd ceph-osd \
       %{_bindir}/ceph-osd-classic 100

As this is the standard RPM practice for file-to-symlink transitions, as documented in the Fedora packaging guidelines. No hacks, no file manipulation, just proper use of the RPM scriptlet ordering.

Sources:

Matan-B · 2025-12-11T08:44:32Z

@cbodley Thanks for testing.

@Matan-B I realized that the right fix is to use
    fi
    %endif

-  %post osd-classic
+  %posttrans osd-classic
   %{_sbindir}/update-alternatives --install %{_bindir}/ceph-osd ceph-osd \
       %{_bindir}/ceph-osd-classic 100
As this is the standard RPM practice for file-to-symlink transitions, as documented in the Fedora packaging guidelines. No hacks, no file manipulation, just proper use of the RPM scriptlet ordering.

Sources:

https://docs.redhat.com/en/documentation/red_hat_enterprise_linux/7/html/rpm_packaging_guide/advanced-topics

https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/

Thanks Kefu! IIUC we still need Obsoletes. right? So that the posttrans scriplet would run afterwards?

tchaikov · 2025-12-11T10:39:59Z

yup, we still need to have Obsoletes in both new packages.

With ceph#65782 merged, upgrading ceph-osd would need to replace the previous ceph-osd existing on the machine. Otherwise, we won't be able to symlink the newly installed package: ``` 2025-12-05T21:09:20.472 INFO:teuthology.orchestra.run.smithi077.stdout: Installing : ceph-osd-classic-2:20.3.0-4434.g8611241d.el9.x86_6 24/87 2025-12-05T21:09:20.478 INFO:teuthology.orchestra.run.smithi077.stdout: Running scriptlet: ceph-osd-classic-2:20.3.0-4434.g8611241d.el9.x86_6 24/87 2025-12-05T21:09:20.479 INFO:teuthology.orchestra.run.smithi077.stdout:failed to link /usr/bin/ceph-osd -> /etc/alternatives/ceph-osd: /usr/bin/ceph-osd exists and it is not a symlink ``` Note: debian/control ceph-osd-classic already had Replace and Breaks: - Breaks is replaced with Conflicts to not allow coexistence. - Release version is bumped up to be relevant for latest main Signed-off-by: Matan Breizman <mbreizma@redhat.com>

Matan-B · 2025-12-11T12:48:56Z

https://shaman.ceph.com/builds/ceph/wip-matanb-crimson-obselte/75f5fabf542fa70eecaf48b997ce1b9bba3ea04a/

looks promising:
https://pulpito.ceph.com/matan-2025-12-11_13:29:42-rgw:singleton-wip-matanb-crimson-obselte-distro-default-smithi/

2025-12-11T13:46:39.823 INFO:teuthology.orchestra.run.smithi202.stdout:  Installing       : lksctp-tools-1.0.19-2.el9.x86_64                       5/8
2025-12-11T13:46:39.835 INFO:teuthology.orchestra.run.smithi168.stdout:  Running scriptlet: ceph-osd-classic-2:20.3.0-4335.g75f5fabf.el9.x86_6   36/36
2025-12-11T13:46:39.866 INFO:teuthology.orchestra.run.smithi202.stdout:  Installing       : hwloc-libs-2.4.1-6.el9.x86_64                          6/8

upgrade testing:
https://pulpito.ceph.com/matan-2025-12-11_14:16:47-rgw:upgrade-wip-matanb-crimson-obselte-distro-default-smithi/

tchaikov · 2025-12-11T14:41:16Z

jenkins test make check arm64

tchaikov · 2025-12-11T14:41:34Z

jenkins test api

cbodley

tyvm @Matan-B @tchaikov

tchaikov · 2025-12-12T01:00:38Z

now that the upgrade tests passed. i am merging this change.

vshankar · 2025-12-18T13:18:18Z

tyvm @Matan-B @tchaikov

Thanks for taking care of this @Matan-B @tchaikov

github-actions bot added the build/ops label Dec 9, 2025

Matan-B requested review from a team, athanatos, cbodley and tchaikov December 9, 2025 09:56

Matan-B added this to Crimson Dec 9, 2025

Matan-B added the crimson label Dec 9, 2025

Matan-B moved this to Needs QA in Crimson Dec 9, 2025

Matan-B added the wip-matan-testing label Dec 9, 2025

Matan-B mentioned this pull request Dec 9, 2025

qa/rgw/upgrade: exclude ceph-osd-classic/crimson on squid and tentacle #66341

Merged

tchaikov reviewed Dec 9, 2025

View reviewed changes

Matan-B force-pushed the wip-matanb-crimson-obselte branch from 1d8274e to 69b37bc Compare December 9, 2025 10:55

Matan-B requested a review from tchaikov December 9, 2025 10:55

Matan-B force-pushed the wip-matanb-crimson-obselte branch from 69b37bc to 16cc623 Compare December 9, 2025 14:07

athanatos removed their request for review December 9, 2025 17:16

tchaikov approved these changes Dec 10, 2025

View reviewed changes

debian/control Outdated Show resolved Hide resolved

Matan-B force-pushed the wip-matanb-crimson-obselte branch from 16cc623 to 75f5fab Compare December 11, 2025 11:55

Matan-B force-pushed the wip-matanb-crimson-obselte branch from 75f5fab to 9f1c8f9 Compare December 11, 2025 11:56

cbodley approved these changes Dec 11, 2025

View reviewed changes

Matan-B moved this from Needs QA to Tested in Crimson Dec 11, 2025

tchaikov merged commit 3eac3d9 into ceph:main Dec 12, 2025
13 checks passed

Matan-B moved this from Tested to Merged (Main) in Crimson Dec 14, 2025

Conversation

Matan-B commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution Guidelines

Checklist

Uh oh!

tchaikov Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

Matan-B Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

Matan-B commented Dec 9, 2025

Uh oh!

cbodley commented Dec 9, 2025

Uh oh!

tchaikov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cbodley commented Dec 10, 2025

Uh oh!

cbodley commented Dec 10, 2025

Uh oh!

tchaikov commented Dec 11, 2025

Uh oh!

Matan-B commented Dec 11, 2025

Uh oh!

tchaikov commented Dec 11, 2025

Uh oh!

Matan-B commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tchaikov commented Dec 11, 2025

Uh oh!

tchaikov commented Dec 11, 2025

Uh oh!

cbodley left a comment

Choose a reason for hiding this comment

Uh oh!

tchaikov commented Dec 12, 2025

Uh oh!

Uh oh!

vshankar commented Dec 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Matan-B commented Dec 9, 2025 •

edited

Loading

Matan-B commented Dec 11, 2025 •

edited

Loading