test/encoding/readable: Add backward incompat checks#66544
Merged
SrinivasaBharath merged 2 commits intoceph:mainfrom Feb 18, 2026
Merged
Conversation
Member
|
jenkins test api |
rzarzynski
approved these changes
Dec 16, 2025
da5281e to
12266b5
Compare
Contributor
|
Rados Approved. |
Contributor
|
jenkins test make check |
673eab2 to
8f7fc71
Compare
Contributor
Author
|
Don't merge it yet! i need to check some errors |
8f7fc71 to
d481b9e
Compare
tchaikov
reviewed
Feb 9, 2026
The python script test_readable.py was added for backword and forward compability. maintaining 2 scripts that finally doing the same is west, reverting and using readable.sh and leave the python out. https://tracker.ceph.com/issues/74074 Signed-off-by: Nitzan Mordechai <nmordech@ibm.com>
The readable.sh script has forward incompat checks, but no
backward incompat checks.
This fix will:
1. Add check for backward_incompat directory for each type for specific
objects or all objects with the same type and skip those objects from being tested.
2. Add version comparison helper functions (version_lt, version_le, version_ge,
versions_span) for robust version handling
3. Replace 'sort -n' with 'sort -V' for proper version number sorting
4. Add CORPUS_PATH environment variable to allow teuthology tests to execute this script
5. Improve readability of the script
The difference between backward and forward incompat:
- forward_incompat: Marks objects from older versions that newer ceph-dencoder
versions cannot read. Example: Version 19.2.x objects marked incompat at version 20.2.x
means ceph-dencoder v20.2.x+ can't decode them. Skip when testing old objects
with a new ceph-dencoder.
- backward_incompat: Marks objects from newer versions that older ceph-dencoder
versions cannot read. Example: Version 19.2.x objects marked backward_incompat at v19.2.x
means ceph-dencoder < v19.2.x can't decode them. Skip when testing new objects
with an old ceph-dencoder.
Fixes: https://tracker.ceph.com/issues/74074
Signed-off-by: Nitzan Mordechai <nmordech@ibm.com>
d481b9e to
011b25d
Compare
Contributor
|
@NitzanMordhai: is this still a DNM? |
Member
|
Let's re-add "needs-qa" when it's ready again. |
Contributor
Author
i made some changes, and like @ljflores mention, lets re add the needs qa and remove DNM |
Member
|
jenkins test signed |
Member
|
jenkins test submodules |
This was referenced Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
readable.sh script have forward incompat checheck, but no backward incompat checks.
the fix will add check for backward_incompat directory for each type for specific object or all objects with the same type and skip those object form being test.
the different between backward and forward incompat:
forward_incompat: Marks objects from older versions that newer ceph-dencoder versions cannot read. Example: Version 19.2.x objects marked incompat at version 20.2.x means ceph-dencoder v20.2.x+ can't decode them. Skip when testing old objects with a new ceph-dencoder.
backward_incompat: Marks objects from newer versions that older ceph-dencoder versions cannot read. Example: Version 19.2.x objects marked backward_incompat at v19.2.x means ceph-dencoder < v19.2.x can't decode them. Skip when testing new objects with an old ceph-dencoder.
https://tracker.ceph.com/issues/74074
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job DefinitionYou must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.