qa/config/crimson_qa_overrides: cephadm to use crimson binary#66458
Closed
qa/config/crimson_qa_overrides: cephadm to use crimson binary#66458
Conversation
eb806d0 to
ad89bf5
Compare
ad89bf5 to
9b87f33
Compare
Previously we were using a crimson dedicated images, `ceph-osd` is no longer overriden when Crimson is enabled. See: ceph#65782 for packaged based deployments we are now using: ``` sudo update-alternatives --set ceph-osd /usr/bin/ceph-osd-crimson ``` containerized deployments should also be able to use crimson-osd when both osd are available in the image. extra_container_args would allow to pass additional arguments directly to the container at runtime and applied (ceph orch apply) Fixes: https://tracker.ceph.com/issues/73970 Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Similarly to e194cca. "ceph.py" now uses "crimson_compat" instead of relying on the flavor of the image. "cephadm.py" could reuse this logic so that the is_crimson method would also work for cephadm. Signed-off-by: Matan Breizman <mbreizma@redhat.com>
9b87f33 to
d6d7304
Compare
Contributor
|
This PR is reasonable as is and is a good way to make progress testing crimson with cephadm. I think the next step (future PRs) would be:
|
athanatos
approved these changes
Dec 2, 2025
Contributor
Author
|
I'll need to test this along with #66217 or enable a new cephadm test since we don't have any yet. |
Contributor
Author
Agreed, tracked here: https://tracker.ceph.com/issues/74081 |
Contributor
|
Contributor
Author
Yes, thank you! Please note the PR currently only changes qa directory and does not require a dedicated build as we can pass qa "testing-branch" directly when scheduling a job. |
Contributor
Author
|
Supporting crimson within cephadm natively is far better option - #66811. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we were using a crimson dedicated images,
ceph-osdis no longer overriden when Crimson is enabled. See: #65782for packaged based deployments we are now using:
containerized deployments should also be able to use crimson-osd when both osd are available in the image.
extra_container_argswould allow to pass additional arguments directly to the container at runtime and applied (ceph orch apply)Fixes: https://tracker.ceph.com/issues/73970
Related pr : ceph/ceph-build#2497
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job DefinitionYou must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.