Open
Conversation
Contributor
Author
|
I think this contains the fix for evict crashes on older versions |
Contributor
Author
|
will add a tracker for that and update the commit msg |
d50b500 to
c0405ef
Compare
14 tasks
dang
approved these changes
Jan 8, 2026
Contributor
dang
left a comment
There was a problem hiding this comment.
Looks good, but the "Bucket cache entry cleanup in progress" commit does nothing and is later reverted, so it should probably be removed.
Member
|
@mattbenjamin : is this ready for the needs-qa label? |
14 tasks
Fixes crash induced by taking the address of the last element of an empty intrusive list (!). Also, introduces active queue, reducing potential for lock contention in evict_block(): * entries are tracked on lane::active_queue when lru_refcnt > 1 ** on some lane::q otherwise Object transition between queues when lru_refcnt changes value-- a value of 0 triggers deletion, as before. Fixes: https://tracker.ceph.com/issues/73992 Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
18cffeb to
e84af3a
Compare
Contributor
Author
|
this has now passed a teuthology run: https://pulpito.ceph.com/mbenjamin-2026-02-25_21:45:37-rgw-wip-posix-lru-distro-default-trial/ |
Contributor
Author
|
jenkins test make check |
Contributor
Author
|
jenkins test make check arm64 |
Contributor
Author
|
@dang missed your comment before about the 'in progress' commit; most of that should be removed, yes; will clean up and merge into the following commit |
* avoids leak of database handles during eviction Also adds missing return-ref in invalidate_entry--this would leak a cache entry. With this change, we can now tolerate indefinite s3-test runs wit rgw_posix_cache_max_buckets=100. Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
e84af3a to
c100c02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job DefinitionYou must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.