Skip to content

tentacle: rgw/s3: Always include x-amz-content-sha256 header in AWS v4 signatures#66358

Open
mheler wants to merge 2 commits intoceph:tentaclefrom
mheler:backport_73496
Open

tentacle: rgw/s3: Always include x-amz-content-sha256 header in AWS v4 signatures#66358
mheler wants to merge 2 commits intoceph:tentaclefrom
mheler:backport_73496

Conversation

@mheler
Copy link
Contributor

@mheler mheler commented Nov 21, 2025

@mheler mheler requested a review from a team as a code owner November 21, 2025 12:49
@github-actions github-actions bot added the rgw label Nov 21, 2025
@github-actions github-actions bot added this to the tentacle milestone Nov 21, 2025
@soumyakoduri
Copy link
Contributor

soumyakoduri commented Nov 22, 2025

jenkins test api

@cbodley
Copy link
Contributor

cbodley commented Nov 24, 2025

thanks @mheler - for backports, please cherry-pick with -x so the commit message contains "(cherry picked from commit xyz)" (see https://github.com/ceph/ceph/blob/main/SubmittingPatches-backports.rst#cherry-picking-rules)

@mheler
rgw/s3: Always include x-amz-content-sha256 header in AWS v4 signatur…
619c14d 
…es for S3 compatibility

Signed-off-by: Matthew N. Heler <matthew.heler@hotmail.com>
(cherry picked from commit 4429c7b)
@mheler
Copy link
Contributor Author

mheler commented Nov 24, 2025

thanks @mheler - for backports, please cherry-pick with -x so the commit message contains "(cherry picked from commit xyz)" (see https://github.com/ceph/ceph/blob/main/SubmittingPatches-backports.rst#cherry-picking-rules)

@cbodley thanks that should be fixed now!

@adamemerson
Copy link
Contributor

adamemerson commented Feb 2, 2026

Removing needs-qa until we have notifiaction/multisite fixes backported to tentacle.

@mheler
Copy link
Contributor Author

mheler commented Feb 4, 2026

@adamemerson this backport is needed to fix cloud-transition for non-AWS S3 providers.

@ceph-jenkins
Copy link
Collaborator

ceph-jenkins commented Feb 4, 2026

Can one of the admins verify this patch?

@smanjara smanjara mentioned this pull request Mar 3, 2026
Merged
@smanjara
Copy link
Contributor

smanjara commented Mar 3, 2026

@mheler this change in main branch caused a regression for multisite https://tracker.ceph.com/issues/74579. while it was resolved in 'main', would you please include the changes from the associated PR #67083 in this PR, so we don't have to track a separate fix for tentacle?

@mheler
rgw/auth: a forwarded CreateBucket request in case of multisite has a…
565cf2a 
…n empty

payload hash computed for UNSIGNED-PAYLOAD. use that hash for the header
'x-amz-content-sha256' in AWSSignerV4::prepare()

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>
(cherry picked from commit 5d35671)
@mheler
Copy link
Contributor Author

mheler commented Mar 3, 2026

@mheler this change in main branch caused a regression for multisite https://tracker.ceph.com/issues/74579. while it was resolved in 'main', would you please include the changes from the associated PR #67083 in this PR, so we don't have to track a separate fix for tentacle?

Done.

@smanjara
Copy link
Contributor

smanjara commented Mar 3, 2026

@mheler this change in main branch caused a regression for multisite https://tracker.ceph.com/issues/74579. while it was resolved in 'main', would you please include the changes from the associated PR #67083 in this PR, so we don't have to track a separate fix for tentacle?

Done.

thank you!

@smanjara smanjara self-requested a review March 3, 2026 20:03
@mheler
Copy link
Contributor Author

mheler commented Mar 20, 2026

@smanjara are we good to merge this? or do we need to do further qa testing?

@mheler mheler requested review from cbodley and smanjara March 20, 2026 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smanjara smanjara Awaiting requested review from smanjara

@cbodley cbodley Awaiting requested review from cbodley

Assignees

No one assigned

Labels

rgw

Projects

None yet

Milestone

tentacle

Development

Successfully merging this pull request may close these issues.

7 participants

@mheler @soumyakoduri @cbodley @adamemerson @ceph-jenkins @smanjara @yuriw