Skip to content

mon/HealthMonitor: avoid MON_DOWN for freshly added Monitor#66328

Merged
batrick merged 4 commits intoceph:mainfrom
batrick:monmap-mon-added
Dec 2, 2025
Merged

mon/HealthMonitor: avoid MON_DOWN for freshly added Monitor#66328
batrick merged 4 commits intoceph:mainfrom
batrick:monmap-mon-added

Conversation

@batrick
Copy link
Member

@batrick batrick commented Nov 19, 2025

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

You must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.

@github-actions
Copy link

Config Diff Tool Output

+ added: mon_down_added_grace (mon.yaml.in)
! changed: mon_down_mkfs_grace: old:  (mon.yaml.in)
! changed: mon_down_mkfs_grace: new: ['runtime'] (mon.yaml.in)

The above configuration changes are found in the PR. Please update the relevant release documentation if necessary.
Ignore this comment if docs are already updated. To make the "Check ceph config changes" CI check pass, please comment /config check ok and re-run the test.

@batrick
Copy link
Member Author

batrick commented Nov 19, 2025

/config check ok

@batrick batrick force-pushed the monmap-mon-added branch 6 times, most recently from b23cfe3 to 1fd10dc Compare November 22, 2025 18:01
Copy link
Contributor

@bill-scales bill-scales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
So we know when the Monitor was added to the map.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
In testing, we often have the scenario where cephadm has created a
cluster but doesn't add more monitors until well past
mon_down_mkfs_grace. This causes useless MON_DOWN warnings to be thrown
which fails QA jobs. Avoid this situation entirely by giving a
reasonable grace period for a monitor added to the MonMap to join
quorum.

Fixes: https://tracker.ceph.com/issues/73934
Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
@batrick
Copy link
Member Author

batrick commented Dec 1, 2025

jenkins test windows

@batrick batrick closed this Dec 1, 2025
@batrick batrick reopened this Dec 1, 2025
@batrick
Copy link
Member Author

batrick commented Dec 1, 2025

https://tracker.ceph.com/issues/73889

Resolved the warning in this QA run.

@batrick
Copy link
Member Author

batrick commented Dec 1, 2025

jenkins test api

@batrick batrick merged commit 00ec7d9 into ceph:main Dec 2, 2025
21 checks passed
@batrick batrick deleted the monmap-mon-added branch December 2, 2025 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants