test/lazy-omap-stats: overload get_output() to accept both lvalue and…#66277
Merged
rzarzynski merged 1 commit intoceph:mainfrom Dec 15, 2025
Merged
Conversation
rzarzynski
approved these changes
Nov 17, 2025
| int num_not_clean; | ||
| do { | ||
| string dump_output = get_output(std::move(command), true); | ||
| do { |
Contributor
There was a problem hiding this comment.
nit: new extra spacing.
| const std::string& command, | ||
| const bool silent = false, | ||
| const CommandTarget target = CommandTarget::TARGET_MGR) { | ||
| return get_output(std::string(command), silent, target); // delegate to rvalue version |
Contributor
There was a problem hiding this comment.
OK, even if if hadn't sharing optimizations in std::string, nobody would have cared in this case.
… rvalue refs PR ceph#65014 added std::move() inside the while loop, which required recreating the command string on each iteration. Add const std::string& overload that forwards to the existing std::string&& version, allowing the command to be declared outside the loop for better efficiency. Fixes: https://tracker.ceph.com/issues/73838 Signed-off-by: Nitzan Mordechai <nmordech@ibm.com>
0be747b to
3e107ec
Compare
rzarzynski
approved these changes
Nov 24, 2025
Contributor
|
RADOS Approved: https://tracker.ceph.com/issues/73968#note-3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… rvalue refs
PR #65014 added std::move() inside the while loop, which required recreating the command string on each iteration.
Add const std::string& overload that forwards to the existing std::string&& version, allowing the command to be declared outside the loop for better efficiency.
Fixes: https://tracker.ceph.com/issues/73838
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job DefinitionYou must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.