Revert "Merge pull request #65940 from Tom-Sollers/fixing_blaum_roth_…#66114
Revert "Merge pull request #65940 from Tom-Sollers/fixing_blaum_roth_…#66114
Conversation
|
The second referenced commit hash leads to a dashboard change set, so I think you have the wrong reference there |
|
+1 on revert until issue is fixed, though |
That's what happens when you do |
Then write a commit message that makes sense, because the auto-generated statement is meaningless. I was sitting here trying to figure out how a dashboard text change is relevant to monitor code and check that the merge revert did the right thing (it got fixed, but in older git releases they were super broken). |
There is value in a standardized commit message for processes automated by tooling; it builds confidence that I didn't do anything manually which could introduce human error. In any case, the automated message is technically correct and clear so I do not see any reason to change it. |
…for_ec_profiles"
This reverts commit a222787, reversing changes made to cf11d9d.
This was not QA'd or reviewed by SME for mon code changes.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job DefinitionYou must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.