rgw/frontend: fix typo in function name#66107
Conversation
regression from: d8a3f3e Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
|
jenkins test api |
|
@h3nryc0ding could you please review? |
henrichter
left a comment
There was a problem hiding this comment.
LGTM. Thanks for addressing this and sorry for the oversight!
i couldn't figure out from https://tracker.ceph.com/issues/73623 how this typo got through qa to break the build on main. the linked git branch does show this typo, but the linked shaman builds were all green for the same sha1 i guess this is another difference between ceph-dev-build and ceph-dev-pipeline. from https://shaman.ceph.com/builds/ceph/main/ i see the failed ubuntu jammy build yesterday, but the more recent builds are all green. it looks like we finally switched over to ceph-dev-pipeline for main, where logs for ubuntu jammy are now showing gcc-12.3.0 instead gcc-11.4.0 |
centos 9 builds are supposed to install and use gcc-toolset-13 |
i ran |
yes, and it's supposed to dump this error message if your default gcc is older: https://github.com/ceph/ceph/blob/70417d2173/install-deps.sh#L257-L263 i see this warning was never added for centos 9, though, so opened #66122 to add it back |
nevermind, i tested in a vm and it worked: #66122 (comment) |
regression from: d8a3f3e
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job DefinitionYou must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.