Skip to content

mgr: serialize python objects sent between subinterpreters via remote#66071

Closed
athanatos wants to merge 2 commits intoceph:mainfrom
athanatos:sjust/for-review/wip-mgr-serialize
Closed

mgr: serialize python objects sent between subinterpreters via remote#66071
athanatos wants to merge 2 commits intoceph:mainfrom
athanatos:sjust/for-review/wip-mgr-serialize

Conversation

@athanatos
Copy link
Contributor

Show available Jenkins commands

You must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.

@athanatos athanatos requested a review from a team as a code owner October 27, 2025 22:49
Copy link
Contributor

@NitzanMordhai NitzanMordhai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@athanatos
Copy link
Contributor Author

Breaks on casual cephadm bootstrap, working on it. @jecluis

@athanatos athanatos force-pushed the sjust/for-review/wip-mgr-serialize branch from 251d970 to 63ceabe Compare October 29, 2025 22:15
@athanatos athanatos requested a review from a team as a code owner October 29, 2025 22:15
@athanatos
Copy link
Contributor Author

athanatos commented Oct 29, 2025

Slight error reporting improvement, added __getnewargs__ to hopefully fix ServiceSpec unpickling.

@athanatos
Copy link
Contributor Author

cephadm bootstrap seems to work (on c9, at least) with this fix

@athanatos
Copy link
Contributor Author

jenkins test make check

@athanatos
Copy link
Contributor Author

jenkins test make check arm64

@athanatos
Copy link
Contributor Author

jenkins test docs

Signed-off-by: Samuel Just <sjust@redhat.com>
…to allow unpickle to work correctly

Signed-off-by: Samuel Just <sjust@redhat.com>
@athanatos athanatos force-pushed the sjust/for-review/wip-mgr-serialize branch from 63ceabe to 8b959da Compare November 5, 2025 01:39
@athanatos
Copy link
Contributor Author

jenkins test make check

@athanatos
Copy link
Contributor Author

jenkins test make check arm64

Copy link
Contributor

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cpython stuff and flow looks generally ok to me, even tho I struggle to follow some of the c++isms.

@athanatos
Copy link
Contributor Author

jenkins test make check

@athanatos
Copy link
Contributor Author

jenkins test make check arm64

@athanatos
Copy link
Contributor Author

Replaced by #66240 -- identical sha1, but make check doesn't seem to work on branches with a '/' in the name.

@athanatos athanatos closed this Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants