Skip to content

RGW/s3select : variables initialization #66067

Merged
galsalomon66 merged 1 commit intoceph:mainfrom
galsalomon66:s3select-csv-initialize-variables-on-construction
Nov 11, 2025
Merged

RGW/s3select : variables initialization #66067
galsalomon66 merged 1 commit intoceph:mainfrom
galsalomon66:s3select-csv-initialize-variables-on-construction

Conversation

@galsalomon66
Copy link
Contributor

@galsalomon66 galsalomon66 commented Oct 27, 2025

initializing of
enable_progress
length_before_processing
length_post_processing on construction.

these variable are getting initialized on s3select/CSV flow, no valgrind local run had discovered any issue related to these variables.
valgrind reports produced by teuthology points on run_s3select_on_csv to contain UninitCondition warning. sometimes.

https://tracker.ceph.com/issues/64832

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

You must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.

@galsalomon66 galsalomon66 requested a review from a team as a code owner October 27, 2025 17:31
@github-actions github-actions bot added the rgw label Oct 27, 2025
@galsalomon66 galsalomon66 marked this pull request as draft October 27, 2025 17:40
@cbodley
Copy link
Contributor

cbodley commented Oct 30, 2025

@galsalomon66 this looks trivial and harmless to merge, is there a reason you converted to draft?

@galsalomon66
Copy link
Contributor Author

galsalomon66 commented Oct 30, 2025

@galsalomon66 this looks trivial and harmless to merge, is there a reason you converted to draft?

ceph.client.0.log.valgrind_demangled_symbols.gz
@cbodley
yeah, the fix is trivial, its for the uninitcondition , as mentioned, it did not re-produce localy with various workload.

but, the attached valgrind report contains great amount of valgrind-reports, different stack (including parsing statement phase), and much more severe. (it is mentioned in tracker)
not clear how this happen, since no change to engine-code or test-code for sometime.

we can merge this one, and continue with the investigation.

@galsalomon66 galsalomon66 marked this pull request as ready for review October 30, 2025 16:44
@cbodley
Copy link
Contributor

cbodley commented Oct 30, 2025

jenkins test docs

3 similar comments
@galsalomon66
Copy link
Contributor Author

jenkins test docs

@galsalomon66
Copy link
Contributor Author

jenkins test docs

@cbodley
Copy link
Contributor

cbodley commented Nov 6, 2025

jenkins test docs

@cbodley
Copy link
Contributor

cbodley commented Nov 6, 2025

jenkins test docs

:( @galsalomon66 i'm pretty sure this has been resolved elsewhere. can you try rebasing to see if that helps?

…processing on construction.

these variable are getting initialized on s3select/CSV flow, no valgrind local run had discovered any issue related to these variables.
valgrind reports produced by teuthology points on run_s3select_on_csv to contain UninitCondition warning. sometimes.

Signed-off-by: galsalomon66 <gal.salomon@gmail.com>
@galsalomon66 galsalomon66 force-pushed the s3select-csv-initialize-variables-on-construction branch from f1c687b to af7870f Compare November 10, 2025 13:17
@galsalomon66 galsalomon66 merged commit a46507a into ceph:main Nov 11, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants