client: signal waitfor_commit waiters for write delegation enabled inode#66036
client: signal waitfor_commit waiters for write delegation enabled inode#66036
Conversation
Fixes: http://tracker.ceph.com/issues/73624 Signed-off-by: Venky Shankar <vshankar@redhat.com> Tested-by: Suhas Athani <sathani@redhat.com>
|
This PR is under test in https://tracker.ceph.com/issues/73647. |
|
jenkins retest this please |
|
jenkins retest this please |
chrisphoffman
left a comment
There was a problem hiding this comment.
I see that you changed this from being specific to fsync to inside of put_cap_ref. Are there any cases other than fsync we should create a test for when when is_write_deleted == true? For example put_cap_ref(in, CEPH_CAP_FILE_BUFFER) happens during _write and _fallocate
Good question. IMO it does not matter for _fallocate() since _fallocate() does not drop client_lock and wait for cap_ref for Fb to drop to the lowest value (0 or 1) depending if write delegations have been handed over. |
|
jenkins test api |
Fixes: http://tracker.ceph.com/issues/73624
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job DefinitionYou must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.