Skip to content

client: fix dump_mds_requests to valid json format#66025

Merged
vshankar merged 1 commit intoceph:mainfrom
Rethan:fix-dump-mds-request-output-json
Nov 6, 2025
Merged

client: fix dump_mds_requests to valid json format#66025
vshankar merged 1 commit intoceph:mainfrom
Rethan:fix-dump-mds-request-output-json

Conversation

@Rethan
Copy link
Contributor

@Rethan Rethan commented Oct 22, 2025

Usually asok command output will be valid json, but mds_requests outputs duplicate key "request", which is not convenient for subsequent parsing.

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

You must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.

@github-actions github-actions bot added the cephfs Ceph File System label Oct 22, 2025
@Rethan
Copy link
Contributor Author

Rethan commented Oct 22, 2025

before
ceph daemon /var/run/ceph/ceph-client.admin.242542.94598455582560.asok mds_requests
{
"request": {
"tid": 34272,
"op": "lookup",
……
},
"request": {
"tid": 34273,
"op": "unlink",
……
}
}
after
ceph daemon /var/run/ceph/ceph-client.admin.203744.94303651090288.asok mds_requests
{
"requests": [
{
"tid": 46083,
"op": "lookup",
……
},
{
"tid": 46084,
"op": "unlink",
……
}
]
}

Copy link
Member

@batrick batrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a tracker issue so that this issue can be tracked for backporting.

Then, please annotate the commit which fixes/resolves a Ceph tracker issue with:

Fixes: http://tracker.ceph.com/issues/...

This is essential when examining the history of the repository (this commit fixes what) and helps merge scripts identify issues that have been resolved by a merge. See this article on GitHub on how to amend commits and update your pull request.

@vshankar vshankar requested a review from a team October 23, 2025 08:06
@Rethan Rethan force-pushed the fix-dump-mds-request-output-json branch from 7a03567 to 487ff3c Compare October 26, 2025 04:28
@vshankar
Copy link
Contributor

This PR is under test in https://tracker.ceph.com/issues/73647.

Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vshankar
Copy link
Contributor

vshankar commented Nov 3, 2025

jenkins test docs

@vshankar
Copy link
Contributor

vshankar commented Nov 4, 2025

@Rethan can you rebase and repost (trying to get RTD checks pass).

Usually asok command output will be valid json, but mds_requests
outputs duplicate key "request", which is not convenient for
subsequent parsing.

Fixes: http://tracker.ceph.com/issues/73639

Signed-off-by: haoyixing <haoyixing03@kuaishou.com>
@Rethan Rethan force-pushed the fix-dump-mds-request-output-json branch from 487ff3c to 326fb61 Compare November 6, 2025 06:15
@Rethan
Copy link
Contributor Author

Rethan commented Nov 6, 2025

@Rethan can you rebase and repost (trying to get RTD checks pass).

@vshankar Rebased and tests have passed.

@vshankar vshankar merged commit 865e9ce into ceph:main Nov 6, 2025
13 checks passed
@Rethan Rethan deleted the fix-dump-mds-request-output-json branch November 7, 2025 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cephfs Ceph File System

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants