squid: client: crash caused by invalid iterator in _readdir_cache_cb#65974
Open
joscollin wants to merge 1 commit intoceph:squidfrom
Open
squid: client: crash caused by invalid iterator in _readdir_cache_cb#65974joscollin wants to merge 1 commit intoceph:squidfrom
joscollin wants to merge 1 commit intoceph:squidfrom
Conversation
Capacity of `readdir_cache` may change after `client_lock` is unlocked in iterations of `readdir_cache`, and it can cause the iterator to be invalid, then using the invalid iterator in the next iteration will cause crash. Crash may happen at `Dentry *dn = *pd` (pd points to invalid memory), or at `if (pd >= dir->readdir_cache.end() || *pd != dn)` (pd is smaller than begin() if idx is negative). Use index instead of iterator to solve this problem. Fixes: https://tracker.ceph.com/issues/72247 Signed-off-by: Zhansong Gao <zhsgao@hotmail.com> (cherry picked from commit 9e0488d)
Member
Author
|
This PR is under test in https://tracker.ceph.com/issues/73568. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/72846
backport of #64627
parent tracker: https://tracker.ceph.com/issues/72247
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh