mds: Remove unnecessary std::move in MetricsHandler#65884
Merged
Conversation
…er::handle_payload Fixes: https://tracker.ceph.com/issues/73430 Signed-off-by: Edwin Rodriguez <edwin.rodriguez1@ibm.com>
3f3db74 to
8d1033e
Compare
Contributor
Author
|
jenkins test windows |
vshankar
approved these changes
Oct 21, 2025
Contributor
|
This PR is under test in https://tracker.ceph.com/issues/73647. |
batrick
approved these changes
Oct 27, 2025
| dout(20) << " accumulating subv_metric " << payload.subvolume_metrics[i] << dendl; | ||
| vec.emplace_back(std::move(payload.subvolume_metrics[i])); | ||
| // std::move of the const expression of the trivially-copyable type 'const value_type' | ||
| // (aka 'const AggregatedIOMetrics') has no effect; remove std::move() |
Member
There was a problem hiding this comment.
no need to keep this comment IMO
Contributor
Author
There was a problem hiding this comment.
I didn't want somebody in the future thinking it would be clever to put back the std::move here
vshankar
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unnecessary std::move on const expression in MetricsHandler::handle_payload
Fixes: https://tracker.ceph.com/issues/73430
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job DefinitionYou must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.