Skip to content

qa: Fix race hazard in repeer-on-acting-back.sh#65831

Closed
bill-scales wants to merge 1 commit intoceph:mainfrom
bill-scales:issue70949
Closed

qa: Fix race hazard in repeer-on-acting-back.sh#65831
bill-scales wants to merge 1 commit intoceph:mainfrom
bill-scales:issue70949

Conversation

@bill-scales
Copy link
Contributor

@bill-scales bill-scales commented Oct 8, 2025

Test script was using sleep to try and catch an OSD in the middle of a backfill, sometimes the OSD was too fast and completed the backfill before the script could query the state of the OSD.

Fix the script to use the backfill_toofull error inject to block the backfill from completing so the script can test the acting set is correctly before removing the error inject and allowing the backfill to complete

Fixes: https://tracker.ceph.com/issues/70949
Fixes: https://tracker.ceph.com/issues/71071

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

You must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.

Test script was using sleep to try and catch an OSD in the middle
of a backfill, sometimes the OSD was too fast and completed the
backfill before the script could query the state of the OSD.

Fix the script to use the backfill_toofull error inject to block
the backfill from completing so the script can test the
acting set is correctly before removing the error inject and
allowing the backfill to complete

Fixes: https://tracker.ceph.com/issues/70949
Fixes: https://tracker.ceph.com/issues/71071
Signed-off-by: Bill Scales <bill_scales@uk.ibm.com>
@bill-scales
Copy link
Contributor Author

See also #65433 which is an alternative fix to this test script

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@bill-scales
Copy link
Contributor Author

Alternative fix in #65433 was merged instead

@bill-scales bill-scales closed this Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant