squid: mds: fix rank 0 marked damaged if stopping fails after Elid flush.#65823
Open
joscollin wants to merge 1 commit intoceph:squidfrom
Open
squid: mds: fix rank 0 marked damaged if stopping fails after Elid flush.#65823joscollin wants to merge 1 commit intoceph:squidfrom
joscollin wants to merge 1 commit intoceph:squidfrom
Conversation
… log trimmed steps to reproduce ../src/vstart.sh --debug --new -x --localhost --bluestore ./bin/ceph tell mds.<rank 0> config set mds_kill_shutdown_at 10 ./bin/ceph fs set <fs name> down true wait for a few seconds and will see the following log from take-over mds and rank 0 is marked damaged 2025-09-11T16:47:24.591+0800 785dabeaa6c0 -1 log_channel(cluster) log [ERR] : No subtrees found for root MDS rank! 2025-09-11T16:47:24.591+0800 785dabeaa6c0 5 mds.beacon.b set_want_state: up:rejoin -> down:damaged During shutdown_pass after submitting Elid and trimming mdlog, mds log will now have only ELid event which does nothing at replay. After replay, no subtree is found. Fix this by checking whther MDLog contains only one event. If so, skip the subtree check for rank 0, and allow it to request STATE_STOPPED just like the other ranks. Fixes: https://tracker.ceph.com/issues/72983 Signed-off-by: ethanwu <ethanwu@synology.com> (cherry picked from commit adb448b)
Member
Author
|
jenkins test make check |
Member
Author
|
This PR is under test in https://tracker.ceph.com/issues/73560. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/73301
backport of #65483
parent tracker: https://tracker.ceph.com/issues/72983
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh