Skip to content

squid: mgr/snap_schedule: handle volume delete#65800

Open
joscollin wants to merge 4 commits intoceph:squidfrom
joscollin:wip-69355-squid
Open

squid: mgr/snap_schedule: handle volume delete#65800
joscollin wants to merge 4 commits intoceph:squidfrom
joscollin:wip-69355-squid

Conversation

@joscollin
Copy link
Member

@joscollin joscollin commented Oct 6, 2025 •
edited
Loading

backport tracker: https://tracker.ceph.com/issues/69355

backport of #55145
parent tracker: https://tracker.ceph.com/issues/63999

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

@mchangir @joscollin
mgr/snap_schedule: handle volume delete
181ec74 
Remove references to timers and db connection that refer to paths in the
deleted volume.

This is a best case effort and not 100% safe. There can be race
conditions where the db connection is closed while the module is
executing a query on the db while the volume itself is deleted.

Hopefully there won't be many tracebacks seen.

Fixes: https://tracker.ceph.com/issues/63999
Signed-off-by: Milind Changire <mchangir@redhat.com>
(cherry picked from commit 4d2af0c)
@mchangir @joscollin
doc/cephfs: note about volume deletion affecting snap-schedule Manage…
f84fa00 
…r module

Signed-off-by: Milind Changire <mchangir@redhat.com>
(cherry picked from commit 153a698)
@mchangir @joscollin
mgr/volumes: warn about active snap-schedules when volume is deleted
752f2ff 
Signed-off-by: Milind Changire <mchangir@redhat.com>
(cherry picked from commit 5c5102c)
@mchangir @joscollin
mon: emit warning during fs rm
3612553 
Signed-off-by: Milind Changire <mchangir@redhat.com>
(cherry picked from commit dd0c816)
@joscollin joscollin requested review from a team as code owners October 6, 2025 22:45
@github-actions github-actions bot added this to the squid milestone Oct 6, 2025
@joscollin
Copy link
Member Author

joscollin commented Oct 7, 2025

jenkins test make chcek

@joscollin
Copy link
Member Author

joscollin commented Oct 7, 2025

jenkins test make check

1 similar comment
@joscollin
Copy link
Member Author

joscollin commented Oct 13, 2025

jenkins test make check

@joscollin joscollin mentioned this pull request Oct 16, 2025
Closed
@joscollin
Copy link
Member Author

joscollin commented Oct 16, 2025

This PR is under test in https://tracker.ceph.com/issues/73568.

@batrick batrick modified the milestones: squid, v19.2.4 Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cephfs Ceph File System core documentation mon needs-qa pybind wip-jcollin-testing-squid12

Projects

None yet

Milestone

v19.2.4

Development

Successfully merging this pull request may close these issues.

3 participants

@joscollin @batrick @mchangir