squid: mgr/vol: handling the failed non-atomic operation#65799
Open
joscollin wants to merge 2 commits intoceph:squidfrom
Open
squid: mgr/vol: handling the failed non-atomic operation#65799joscollin wants to merge 2 commits intoceph:squidfrom
joscollin wants to merge 2 commits intoceph:squidfrom
Conversation
Member
Author
|
jenkins test make check |
ff54b35 to
4849ff3
Compare
Member
Author
|
jenkins test make check |
Member
Author
|
jenkins test make check |
1 similar comment
Member
Author
|
jenkins test make check |
The order of operation done for subvolume removal with retain-snapshot option set to true, is reversed. The metadata is updated first followed by a rename operation on the uuid directory. If the metadata update operation fails, then the remove operations is failed thereby, keeping the subvolume metadata consistent with the uuid path. Fixes: https://tracker.ceph.com/issues/67330 Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com> (cherry picked from commit ba199cf)
4849ff3 to
3a7c5ba
Compare
… full Fixes: https://tracker.ceph.com/issues/67330 Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com> Conflicts: qa/suites/fs/full/tasks/mgr-osd-full.yaml (cherry picked from commit ea624e4)
3a7c5ba to
200601b
Compare
Member
Author
|
This PR is under test in https://tracker.ceph.com/issues/73568. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/73309
backport of #59676
parent tracker: https://tracker.ceph.com/issues/67330
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job Definition