rgw/dedup: Grant dedup process full RGW permissions. by benhanokh · Pull Request #65783 · ceph/ceph

benhanokh · 2025-10-05T08:37:35Z

This is necessary to allow for the creation of intermediate SLAB objects on systems configured with Ceph authentication.

Contribution Guidelines

To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

Tracker (select at least one)
- References tracker ticket
- Very recent bug; references commit where it was introduced
- New feature (ticket optional)
- Doc update (no ticket needed)
- Code cleanup (no ticket needed)
Component impact
- Affects Dashboard, opened tracker ticket
- Affects Orchestrator, opened tracker ticket
- No impact that needs to be tracked
Documentation (select at least one)
- Updates relevant documentation
- No doc update is appropriate
Tests (select at least one)
- Includes unit test(s)
- Includes integration test(s)
- Includes bug reproducer
- No tests

Show available Jenkins commands

jenkins test classic perf Jenkins Job | Jenkins Job Definition
jenkins test crimson perf Jenkins Job | Jenkins Job Definition
jenkins test signed Jenkins Job | Jenkins Job Definition
jenkins test make check Jenkins Job | Jenkins Job Definition
jenkins test make check arm64 Jenkins Job | Jenkins Job Definition
jenkins test submodules Jenkins Job | Jenkins Job Definition
jenkins test dashboard Jenkins Job | Jenkins Job Definition
jenkins test dashboard cephadm Jenkins Job | Jenkins Job Definition
jenkins test api Jenkins Job | Jenkins Job Definition
jenkins test docs ReadTheDocs | Github Workflow Definition
jenkins test ceph-volume all Jenkins Jobs | Jenkins Jobs Definition
jenkins test windows Jenkins Job | Jenkins Job Definition
jenkins test rook e2e Jenkins Job | Jenkins Job Definition

You must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.

Copilot

Pull Request Overview

This PR fixes a permissions issue with the RGW deduplication process by changing the application type from "rgw_dedup" to "rgw" when enabling pool applications. This change ensures the dedup process has full RGW permissions necessary for creating intermediate SLAB objects on systems with Ceph authentication enabled.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

benhanokh · 2025-10-05T09:49:50Z

jenkins test make check arm64

benhanokh · 2025-10-05T09:49:57Z

jenkins test make check

Copilot

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

src/rgw/driver/rados/rgw_dedup_utils.cc

Copilot

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-06T05:16:57Z

src/rgw/driver/rados/rgw_dedup_utils.cc

+          f->dump_unsigned("Bad default storage class objs (should be identical to ingress_obj)",
+                           this->default_storage_class_objs);


The error message is unclear and doesn't provide actionable information. Consider including both the expected and actual values in the message, such as 'Expected default_storage_class_objs to equal ingress_obj: expected %d, got %d'.

Copilot · 2025-10-06T05:16:58Z

src/rgw/driver/rados/rgw_dedup_utils.cc

+          f->dump_unsigned("Bad default storage class objs bytes (should be identical to ingress_obj_bytes)",
+                           this->default_storage_class_objs_bytes);


Similar to the previous message, this error message should include both expected and actual values for better debugging. Consider a format like 'Expected default_storage_class_objs_bytes to equal ingress_obj_bytes: expected %d, got %d'.

This is necessary to allow for the creation of intermediate SLAB objects on systems configured with Ceph authentication. Remove bogus assert Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2401399 Signed-off-by: Gabriel BenHanokh <gbenhano@redhat.com>

Copilot

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-08T12:52:42Z

src/rgw/driver/rados/rgw_dedup_utils.cc

+        if (this->default_storage_class_objs != this->ingress_obj) {
+          f->dump_unsigned("default storage class objs",
+                           this->default_storage_class_objs);
+        }
+        if (this->default_storage_class_objs_bytes != this->ingress_obj_bytes) {


The replacement of assertions with conditional dumping removes important invariant checks. Consider adding logging to indicate when these conditions occur, as they may represent unexpected states that should be investigated.

Suggested change

if (this->default_storage_class_objs != this->ingress_obj) {

f->dump_unsigned("default storage class objs",

this->default_storage_class_objs);

}

if (this->default_storage_class_objs_bytes != this->ingress_obj_bytes) {

if (this->default_storage_class_objs != this->ingress_obj) {

std::cerr << "[WARN] Unexpected state: default_storage_class_objs (" << this->default_storage_class_objs

<< ") != ingress_obj (" << this->ingress_obj << ")" << std::endl;

f->dump_unsigned("default storage class objs",

this->default_storage_class_objs);

}

if (this->default_storage_class_objs_bytes != this->ingress_obj_bytes) {

std::cerr << "[WARN] Unexpected state: default_storage_class_objs_bytes (" << this->default_storage_class_objs_bytes

<< ") != ingress_obj_bytes (" << this->ingress_obj_bytes << ")" << std::endl;

benhanokh · 2025-10-08T16:36:24Z

jenkins test windows

benhanokh · 2025-10-08T19:24:03Z

jenkins test windows

ivancich · 2025-10-09T14:35:13Z

@benhanokh Is this PR associated with this tracker (https://tracker.ceph.com/issues/72947)? If so, can you link them to each other?

anrao19 · 2025-10-10T05:31:31Z

PR testing completed and approved by @ivancich. Details : https://tracker.ceph.com/issues/73372
@benhanokh , if no further testing is not needed please let me know if this can be merged

benhanokh · 2025-10-10T05:58:55Z

Please merge

benhanokh requested a review from a team as a code owner October 5, 2025 08:37

github-actions bot added the rgw label Oct 5, 2025

benhanokh added the needs-tentacle-backport PRs that need tentacle back-port label Oct 5, 2025

benhanokh self-assigned this Oct 5, 2025

benhanokh requested review from Copilot and removed request for a team October 5, 2025 08:38

Copilot AI reviewed Oct 5, 2025

View reviewed changes

yuvalif approved these changes Oct 5, 2025

View reviewed changes

yuvalif added the needs-qa label Oct 5, 2025

benhanokh force-pushed the dedup_permissions branch from 36febae to aafb8cf Compare October 5, 2025 13:40

benhanokh requested a review from Copilot October 5, 2025 17:03

Copilot AI reviewed Oct 5, 2025

View reviewed changes

src/rgw/driver/rados/rgw_dedup_utils.cc Outdated Show resolved Hide resolved

src/rgw/driver/rados/rgw_dedup_utils.cc Show resolved Hide resolved

benhanokh force-pushed the dedup_permissions branch from ce6e576 to 9518bd6 Compare October 6, 2025 05:15

benhanokh requested a review from Copilot October 6, 2025 05:16

Copilot AI reviewed Oct 6, 2025

View reviewed changes

anrao19 added the wip-anrao5-testing label Oct 6, 2025

benhanokh added the bug-fix label Oct 8, 2025

benhanokh force-pushed the dedup_permissions branch from 9518bd6 to a984ad8 Compare October 8, 2025 12:12

benhanokh requested a review from Copilot October 8, 2025 12:13

Copilot AI reviewed Oct 8, 2025

View reviewed changes

benhanokh requested a review from Copilot October 8, 2025 12:52

Copilot AI reviewed Oct 8, 2025

View reviewed changes

anrao19 added TESTED and removed wip-anrao5-testing labels Oct 10, 2025

anrao19 added the ready-to-merge label Oct 10, 2025

yuvalif merged commit f92cc23 into ceph:main Oct 12, 2025
13 checks passed

		f->dump_unsigned("Bad default storage class objs (should be identical to ingress_obj)",
		this->default_storage_class_objs);

		f->dump_unsigned("Bad default storage class objs bytes (should be identical to ingress_obj_bytes)",
		this->default_storage_class_objs_bytes);

Conversation

benhanokh commented Oct 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution Guidelines

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

benhanokh commented Oct 5, 2025

Uh oh!

benhanokh commented Oct 5, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

benhanokh commented Oct 8, 2025

Uh oh!

benhanokh commented Oct 8, 2025

Uh oh!

ivancich commented Oct 9, 2025

Uh oh!

anrao19 commented Oct 10, 2025

Uh oh!

benhanokh commented Oct 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

benhanokh commented Oct 5, 2025 •

edited

Loading