cephfs-journal-tool: Journal trimming issue#65577
Merged
Conversation
7e9735b to
27ad845
Compare
batrick
approved these changes
Sep 18, 2025
Member
|
27ad845 to
b710c07
Compare
Contributor
Author
Thanks for the quick review. I will fix this up. |
b710c07 to
5b698e7
Compare
vshankar
reviewed
Sep 18, 2025
Validates that the cephfs-journal-tool reset doesn't reset the trim position so that the journal trim takes care of trimming the older unused journal objects helping to recover the space in metadata pool. Fixes: https://tracker.ceph.com/issues/69708 Signed-off-by: Kotresh HR <khiremat@redhat.com>
If the fs had to go through journal recovery and reset, the cephfs-journal-tool resets the journal trim position because of which the old unused journal objects just stay forever in the metadata pool. The patch fixes the issue. Now, the old stale journal objects are trimmed during the regular trimming cycle helping to recover space in the metadata pool. Fixes: https://tracker.ceph.com/issues/69708 Signed-off-by: Kotresh HR <khiremat@redhat.com>
5b698e7 to
4f9a926
Compare
Contributor
Author
|
QA Results validating the test added. Test added fails without the fix against current main branch: Test passes with the fix: |
This was referenced Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cephfs-journal-tool: Don't reset the journal trim position
Fixes: https://tracker.ceph.com/issues/69708
Signed-off-by: Kotresh HR khiremat@redhat.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job DefinitionYou must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.