Skip to content

osd/scrub: relocate some EC CRC collection/usage#65497

Draft
ronen-fr wants to merge 1 commit intoceph:mainfrom
ronen-fr:wip-rf-eccrc
Draft

osd/scrub: relocate some EC CRC collection/usage#65497
ronen-fr wants to merge 1 commit intoceph:mainfrom
ronen-fr:wip-rf-eccrc

Conversation

@ronen-fr
Copy link
Contributor

@ronen-fr ronen-fr commented Sep 11, 2025 •
edited
Loading

... moving it from select_auth_shard() into two separate
auxiliary methods, one for collecting the CRCs, and one
for recreating the object from the available CRCs.

unstale 1

@github-actions github-actions bot added the core label Sep 11, 2025
@github-actions
Copy link

github-actions bot commented Sep 16, 2025

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@ronen-fr
osd/scrub: relocate some EC CRC collection/usage
2a979df 
Moving it from select_auth_shard() into two separate
auxiliary methods, one for collecting the CRCs, and one
for recreating the object from the available CRCs.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
@ronen-fr ronen-fr marked this pull request as ready for review September 20, 2025 08:30
@ronen-fr ronen-fr requested a review from a team as a code owner September 20, 2025 08:30
@ronen-fr
Copy link
Contributor Author

ronen-fr commented Sep 20, 2025

@JonBailey1993 - can you possibly fix/improve the description (function comment) for the suggested redecode_ec_shards()?
(and, if possible - approve the PR...).
Thanks!

@ronen-fr
Copy link
Contributor Author

ronen-fr commented Oct 5, 2025

Downgrading to draft, as it interacts with #65623

@ronen-fr ronen-fr marked this pull request as draft October 5, 2025 11:09
@ronen-fr ronen-fr mentioned this pull request Oct 5, 2025
Merged
14 tasks
@github-actions
Copy link

github-actions bot commented Dec 4, 2025

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Dec 4, 2025
@ronen-fr ronen-fr removed the stale label Dec 11, 2025
@github-actions
Copy link

github-actions bot commented Feb 5, 2026

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JonBailey1993 JonBailey1993 Awaiting requested review from JonBailey1993

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

core needs-rebase

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ronen-fr