Skip to content

mgr/volumes: fix bugs related missing UUID dir from a subvol#65467

Merged
vshankar merged 3 commits intoceph:mainfrom
rishabh-d-dave:vols-force-rm
Feb 23, 2026
Merged

mgr/volumes: fix bugs related missing UUID dir from a subvol#65467
vshankar merged 3 commits intoceph:mainfrom
rishabh-d-dave:vols-force-rm

Conversation

@rishabh-d-dave
Copy link
Contributor

@rishabh-d-dave rishabh-d-dave commented Sep 10, 2025 •
edited
Loading

Fixes: https://tracker.ceph.com/issues/72955
Fixes: https://tracker.ceph.com/issues/72956
Fixes: https://tracker.ceph.com/issues/72957

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

@rishabh-d-dave rishabh-d-dave requested a review from a team September 10, 2025 09:17
@rishabh-d-dave rishabh-d-dave changed the title mgr/volumes: fix bugs related missing UUID dirs from a subvol mgr/volumes: fix bugs related missing UUID dir from a subvol Sep 10, 2025
@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Sep 19, 2025

jenkins test make check

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Sep 19, 2025

jenkins test make check arm64

prallabh
prallabh reviewed Sep 23, 2025
View reviewed changes
@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Oct 1, 2025

@kotreshhr ping

kotreshhr
kotreshhr requested changes Oct 7, 2025
View reviewed changes
@rishabh-d-dave
mgr/volumes: allow --force to delete subvols even when UUID is missing
1ed9eab 
Also, add test for the same.

Fixes: https://tracker.ceph.com/issues/72955
Signed-off-by: Rishabh Dave <ridave@redhat.com>
@rishabh-d-dave
mgr/volumes: allow --force to delete snapshots even when UUID dir is …
87a39a0 
…missing

Also, add tests for the same.

Fixes: https://tracker.ceph.com/issues/72956
Signed-off-by: Rishabh Dave <ridave@redhat.com>
@rishabh-d-dave
mgr/volumes: make clone state transition to fail when UUID dir is mis…
ffa1c11 
…sing...

for the source subvolume. Also add tests for the same.

Fixes: https://tracker.ceph.com/issues/72957
Signed-off-by: Rishabh Dave <ridave@redhat.com>
@github-actions
Copy link

github-actions bot commented Dec 12, 2025

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Dec 12, 2025
@vshankar vshankar removed the stale label Jan 7, 2026
@vshankar
Copy link
Contributor

vshankar commented Jan 7, 2026

@kotreshhr - please plan to re-review this change.

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Jan 29, 2026

jenkins test windows

@vshankar
Copy link
Contributor

vshankar commented Feb 18, 2026

This PR is under test in https://tracker.ceph.com/issues/75005.

@vshankar
Copy link
Contributor

vshankar commented Feb 19, 2026

This PR is under test in https://tracker.ceph.com/issues/75016.

vshankar
vshankar approved these changes Feb 23, 2026
View reviewed changes
Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://tracker.ceph.com/projects/cephfs/wiki/QA_main_2025#wip-vshankar-testing-20260219071614

@vshankar vshankar merged commit 71cab4c into ceph:main Feb 23, 2026
13 checks passed
@vshankar
Copy link
Contributor

vshankar commented Feb 24, 2026

https://tracker.ceph.com/projects/cephfs/wiki/QA_main_2025#wip-vshankar-testing-20260219071614

See: https://tracker.ceph.com/projects/cephfs/wiki/QA_main_--_2026#wip-vshankar-testing-20260219071614 (wiki link updated)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vshankar vshankar vshankar approved these changes

@kotreshhr kotreshhr kotreshhr approved these changes

+1 more reviewer

@prallabh prallabh prallabh left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@kotreshhr kotreshhr

Labels

cephfs Ceph File System needs-review pybind tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rishabh-d-dave @vshankar @prallabh @kotreshhr