client: some improvements for Client.cc#65432
Merged
rishabh-d-dave merged 1 commit intoceph:mainfrom Oct 3, 2025
Merged
Conversation
1. Log entry is too short and multiple member functions can have same directory and therefore it's best to prefix log entry with member function's name so that it is easy to locate it in codebase. 2. Variable name "err" doesn't necessarily hold error code but may hold a generic return value as well. Renaming it to "retval" will mildly and quietly emphasize this to the reader. 3. Fix log entry in _rmdir() which incorrectly prefixes itself with "rmdir". Signed-off-by: Rishabh Dave <ridave@redhat.com>
joscollin
approved these changes
Sep 9, 2025
Member
joscollin
left a comment
There was a problem hiding this comment.
The retval is a bit unnecessary, but there's no harm. Approving this.
Contributor
Author
"err" gives a false impression that return value is an error but it's not necessarily so. |
batrick
approved these changes
Sep 10, 2025
Contributor
Author
|
This PR is under test in https://tracker.ceph.com/issues/73311. |
rishabh-d-dave
commented
Oct 3, 2025
Contributor
Author
rishabh-d-dave
left a comment
There was a problem hiding this comment.
QA run was successful - https://tracker.ceph.com/projects/cephfs/wiki/QA_main_2025#wip-rishabh-testing-20250929182116
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log entry is too short and multiple member functions can have same
directory and therefore it's best to prefix log entry with member
function's name so that it is easy to locate it in codebase.
Variable name "err" doesn't necessarily hold error code but may hold
a generic return value as well. Renaming it to "retval" will mildly and
quietly emphasize this to the reader.
Fix log entry in _rmdir() which incorrectly prefixes itself with "rmdir".
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job Definition