Skip to content

mds: uninline methods to reduce header dependencies and compile times#65392

Merged
vshankar merged 14 commits intoceph:mainfrom
MaxKellermann:mds_uninline
Sep 19, 2025
Merged

mds: uninline methods to reduce header dependencies and compile times#65392
vshankar merged 14 commits intoceph:mainfrom
MaxKellermann:mds_uninline

Conversation

@MaxKellermann
Copy link
Member

@MaxKellermann MaxKellermann commented Sep 4, 2025

Another PR split from #60490

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@github-actions github-actions bot added the cephfs Ceph File System label Sep 4, 2025
@MaxKellermann MaxKellermann force-pushed the mds_uninline branch 2 times, most recently from 9b4a7f3 to a25d671 Compare September 5, 2025 08:17
@MaxKellermann
global/signal_handler: add missing include
359f26a 
Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
@MaxKellermann
tools/cephfs/DataScan: add missing include
f8f581d 
Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
@MaxKellermann
mds/MDCache: un-inline methods to reduce header dependencies
0efecdc 
Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
@MaxKellermann
mds/Mutation: forward-declare MClientRequest and MMDSPeerRequest
8648e61 
Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
@MaxKellermann
mds/MDSRank: un-inline methods to reduce header dependencies
c675484 
Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
@MaxKellermann
mds/MDBalancer: include cleanup
8a87ea9 
Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
@MaxKellermann
mds/SnapServer: include cleanup
0ef4dc9 
Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
@MaxKellermann
mds/Migrator: un-inline methods to reduce compile times
52690e4 
Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
@MaxKellermann
mds/MDSTableClient: include cleanup
3842887 
Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
@MaxKellermann
mds/SnapClient: un-inline encoding methods reduce header dependencies
06c74cc 
Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
@MaxKellermann
mds/SnapServer: un-inline methods to reduce header dependencies
f4e58c2 
Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
@MaxKellermann
mds/snap: include cleanup
c5c21b6 
Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
@MaxKellermann
mds/PurgeQueue: include cleanup
d711d68 
Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
@MaxKellermann
mds/MDSTableServer: forward-declare MMDSTableRequest
8c47f85 
Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
@github-actions github-actions bot added the common label Sep 5, 2025
@MaxKellermann
Copy link
Member Author

MaxKellermann commented Sep 5, 2025

jenkins test make check arm64

@MaxKellermann
Copy link
Member Author

MaxKellermann commented Sep 5, 2025

jenkins test api

1 similar comment
@MaxKellermann
Copy link
Member Author

MaxKellermann commented Sep 8, 2025

jenkins test api

@MaxKellermann MaxKellermann requested review from batrick and vshankar and removed request for batrick September 8, 2025 14:23
@dparmar18 dparmar18 self-assigned this Sep 16, 2025
@MaxKellermann
Copy link
Member Author

MaxKellermann commented Sep 16, 2025

Thanks @dparmar18 - do you want this PR to go through full QA?
Most of my include cleanup PRs could be merged without QA because they were trivial enough, but this one might be above this triviality threshold. IMHO it's still trivial enough, but maintainer opinion is what counts, not mine.

@vshankar
Copy link
Contributor

vshankar commented Sep 16, 2025

Thanks @dparmar18 - do you want this PR to go through full QA? Most of my include cleanup PRs could be merged without QA because they were trivial enough, but this one might be above this triviality threshold. IMHO it's still trivial enough, but maintainer opinion is what counts, not mine.

Better to run this through QA -- maybe just subset of the tests would suffice.

@MaxKellermann
Copy link
Member Author

MaxKellermann commented Sep 16, 2025

Aye, thanks @vshankar!

My most trivial patches have been merged in past PRs already, the bulk of the header bugs have been fixed, and all upcoming patches are like this PR (optimizations, not bug fixes). So I'm keeping my hands off the Merge button.

@vshankar
Copy link
Contributor

vshankar commented Sep 17, 2025

This PR is under test in https://tracker.ceph.com/issues/73082.

@vshankar vshankar merged commit 2b14a67 into ceph:main Sep 19, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vshankar vshankar vshankar approved these changes

@dparmar18 dparmar18 dparmar18 approved these changes

@batrick batrick Awaiting requested review from batrick

Assignees

@dparmar18 dparmar18

Labels

cephfs Ceph File System common

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MaxKellermann @vshankar @dparmar18