os, osd: drop remainings of FileStore#65270
Open
rzarzynski wants to merge 6 commits intoceph:mainfrom
Open
Conversation
Config Diff Tool Output- removed: filestore_max_xattr_value_size_xfs (global.yaml.in)
- removed: filestore_fsync_flushes_journal_data (global.yaml.in)
- removed: filestore_journal_parallel (global.yaml.in)
- removed: filestore_wbthrottle_xfs_inodes_start_flusher (global.yaml.in)
- removed: filestore_zfs_snap (global.yaml.in)
- removed: filestore_ondisk_finisher_threads (global.yaml.in)
- removed: filestore_split_multiple (global.yaml.in)
- removed: filestore_fail_eio (global.yaml.in)
- removed: filestore_queue_max_delay_multiple (global.yaml.in)
- removed: filestore_wbthrottle_btrfs_inodes_start_flusher (global.yaml.in)
- removed: filestore_omap_header_cache_size (global.yaml.in)
- removed: filestore_xfs_extsize (global.yaml.in)
- removed: filestore_fiemap_threshold (global.yaml.in)
- removed: filestore_max_xattr_value_size_other (global.yaml.in)
- removed: filestore_wbthrottle_btrfs_bytes_start_flusher (global.yaml.in)
- removed: filestore_rocksdb_options (global.yaml.in)
- removed: filestore_omap_backend (global.yaml.in)
- removed: filestore_odsync_write (global.yaml.in)
- removed: filestore_min_sync_interval (global.yaml.in)
- removed: filestore_queue_high_delay_multiple_ops (global.yaml.in)
- removed: filestore_wbthrottle_xfs_ios_hard_limit (global.yaml.in)
- removed: filestore_max_xattr_value_size_btrfs (global.yaml.in)
- removed: filestore_max_inline_xattrs (global.yaml.in)
- removed: filestore_apply_finisher_threads (global.yaml.in)
- removed: filestore_wbthrottle_xfs_bytes_hard_limit (global.yaml.in)
- removed: filestore_max_inline_xattr_size_btrfs (global.yaml.in)
- removed: filestore_seek_data_hole (global.yaml.in)
- removed: filestore_split_rand_factor (global.yaml.in)
- removed: filestore_max_inline_xattr_size_other (global.yaml.in)
- removed: filestore_sloppy_crc_block_size (global.yaml.in)
- removed: filestore_max_xattr_value_size (global.yaml.in)
- removed: filestore_dump_file (global.yaml.in)
- removed: filestore_op_thread_timeout (global.yaml.in)
- removed: filestore_debug_inject_read_err (global.yaml.in)
- removed: filestore_blackhole (global.yaml.in)
- removed: filestore_collect_device_partition_information (global.yaml.in)
- removed: filestore_journal_trailing (global.yaml.in)
- removed: filestore_queue_high_delay_multiple_bytes (global.yaml.in)
- removed: filestore_wbthrottle_btrfs_ios_hard_limit (global.yaml.in)
- removed: filestore_queue_max_bytes (global.yaml.in)
- removed: filestore_sloppy_crc (global.yaml.in)
- removed: filestore_queue_high_delay_multiple (global.yaml.in)
- removed: filestore_queue_high_threshhold (global.yaml.in)
- removed: filestore_op_thread_suicide_timeout (global.yaml.in)
- removed: filestore_fd_cache_shards (global.yaml.in)
- removed: filestore_max_alloc_hint_size (global.yaml.in)
- removed: filestore_fd_cache_size (global.yaml.in)
- removed: filestore_queue_low_threshhold (global.yaml.in)
- removed: filestore_inject_stall (global.yaml.in)
- removed: filestore_expected_throughput_bytes (global.yaml.in)
- removed: filestore_max_sync_interval (global.yaml.in)
- removed: filestore_queue_max_delay_multiple_bytes (global.yaml.in)
- removed: filestore_btrfs_snap (global.yaml.in)
- removed: filestore_journal_writeahead (global.yaml.in)
- removed: filestore_caller_concurrency (global.yaml.in)
- removed: filestore_wbthrottle_xfs_inodes_hard_limit (global.yaml.in)
- removed: filestore_index_retry_probability (global.yaml.in)
- removed: filestore_max_inline_xattr_size (global.yaml.in)
- removed: filestore_max_inline_xattrs_btrfs (global.yaml.in)
- removed: filestore_merge_threshold (global.yaml.in)
- removed: filestore_queue_max_delay_multiple_ops (global.yaml.in)
- removed: filestore_op_threads (global.yaml.in)
- removed: filestore_punch_hole (global.yaml.in)
- removed: filestore_wbthrottle_btrfs_inodes_hard_limit (global.yaml.in)
- removed: filestore_update_to (global.yaml.in)
- removed: filestore_omap_backend_path (global.yaml.in)
- removed: filestore_wbthrottle_enable (global.yaml.in)
- removed: filestore_fadvise (global.yaml.in)
- removed: filestore_debug_verify_split (global.yaml.in)
- removed: filestore_splice (global.yaml.in)
- removed: filestore_debug_omap_check (global.yaml.in)
- removed: filestore_kill_at (global.yaml.in)
- removed: filestore_fiemap (global.yaml.in)
- removed: filestore_btrfs_clone_range (global.yaml.in)
- removed: filestore_max_inline_xattr_size_xfs (global.yaml.in)
- removed: filestore_wbthrottle_btrfs_ios_start_flusher (global.yaml.in)
- removed: filestore_wbthrottle_xfs_bytes_start_flusher (global.yaml.in)
- removed: filestore_wbthrottle_btrfs_bytes_hard_limit (global.yaml.in)
- removed: filestore_queue_max_ops (global.yaml.in)
- removed: filestore_wbthrottle_xfs_ios_start_flusher (global.yaml.in)
- removed: filestore_max_inline_xattrs_xfs (global.yaml.in)
- removed: filestore_max_inline_xattrs_other (global.yaml.in)
- removed: filestore_expected_throughput_ops (global.yaml.in)
- removed: filestore_commit_timeout (global.yaml.in)
! changed: osd_objectstore: old: ['bluestore', 'filestore', 'memstore', 'kstore', 'seastore', 'cyanstore'] (global.yaml.in)
! changed: osd_objectstore: new: ['bluestore', 'memstore', 'kstore', 'seastore', 'cyanstore'] (global.yaml.in)
The above configuration changes are found in the PR. Please update the relevant release documentation if necessary. |
cb49f43 to
a428a5b
Compare
a428a5b to
5c864ce
Compare
athanatos
approved these changes
Aug 28, 2025
jdurgin
approved these changes
Sep 3, 2025
Member
|
Grepping shows a bunch of docs still referencing filestore as well |
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
5c864ce to
a5957cd
Compare
Contributor
Author
|
Rebased after a trival conflict with e714636. |
Contributor
|
@rzarzynski |
Contributor
|
Hey @rzarzynski, we came across a couple related failures during teuthology qa: There were a few teuthology runs which look like they are trying to access a now deleted filestore config value: /a/skanta-2025-11-05_00:00:19-rados-wip-bharath7-testing-2025-11-04-1337-distro-default-smithi/8584403 Also, during the QA Analysis I raised this: https://tracker.ceph.com/issues/73915 |
Member
|
Please re-add the "needs-qa" label once the above comment has been addressed. |
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Contributor
Author
|
@ljflores: knocked out the FileStore leftovers in |
Contributor
Contributor
|
jenkins retest this please |
1 similar comment
Contributor
|
jenkins retest this please |
Contributor
|
@rzarzynski - Kindly resolve the failed checks and proceed with merging the pull request once all issues have been fixed. If a retest is required, please add the "needs-qa" label |
Contributor
Author
|
jenkins test make check arm64 |
Contributor
Author
|
jenkins test make check |
Contributor
Author
|
Contributor
Author
|
jenkins test make check |
Contributor
Author
|
jenkins test make check arm64 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job Definition