Skip to content

qa/suites/crimson-rados: run full librbd test suite #65240

Merged
Matan-B merged 2 commits intoceph:mainfrom
knrt10:test-crimson-librbd-reenable
Aug 31, 2025
Merged

qa/suites/crimson-rados: run full librbd test suite #65240
Matan-B merged 2 commits intoceph:mainfrom
knrt10:test-crimson-librbd-reenable

Conversation

@knrt10
Copy link
Member

@knrt10 knrt10 commented Aug 26, 2025

Previously the librbd test runner listed individual gtest filters to work around unstable groups (see tracker #58791). Those workarounds are no longer needed, so the script has been simplified to invoke ceph_test_librbd directly. This ensures the entire suite is always executed and reduces maintenance overhead.

Fixes: https://tracker.ceph.com/issues/58791

Teuthology: https://pulpito.ceph.com/knrt-2025-08-25_12:20:20-crimson-rados-main-distro-crimson-debug-smithi/

Co-authored-by: Matan Breizman mbreizma@redhat.com
Signed-off-by: Kautilya Tripathi kautilya.tripathi@ibm.com

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

knrt10 and others added 2 commits August 25, 2025 11:22
Previously the librbd test runner listed individual gtest filters to
work around unstable groups (see tracker ceph#58791). Those workarounds
are no longer needed, so the script has been simplified to invoke
`ceph_test_librbd` directly. This ensures the entire suite is always
executed and reduces maintenance overhead.

Fixes: https://tracker.ceph.com/issues/58791
Co-authored-by: Matan Breizman <mbreizma@redhat.com>
Signed-off-by: Kautilya Tripathi <kautilya.tripathi@ibm.com>
Since now crimson has all tests enabled some still fails. This skips
them and adds a dedicated tracker for the same.

Co-authored-by: Matan Breizman <mbreizma@redhat.com>
Signed-off-by: Kautilya Tripathi <kautilya.tripathi@ibm.com>
@knrt10 knrt10 requested a review from Matan-B August 26, 2025 12:56
@knrt10 knrt10 requested a review from a team as a code owner August 26, 2025 12:56
@Matan-B Matan-B changed the title qa/tests: run full librbd test suite unconditionally qa/suites/crimson-rados: run full librbd test suite unconditionally Aug 26, 2025
@Matan-B Matan-B added this to Crimson Aug 26, 2025
@Matan-B Matan-B moved this to Needs QA in Crimson Aug 26, 2025
Copy link
Contributor

@Matan-B Matan-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Can you please the rerun the tests so we would make sure all jobs are green prior to merging? Thanks!

@Matan-B
Copy link
Contributor

Matan-B commented Aug 26, 2025

Make check is failing with:

[ RUN      ] TestLibRBD.TestPendingAio
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/run-rbd-unit-tests.sh: line 20: 1738347 Segmentation fault      RBD_FEATURES=$i unittest_librbd

https://jenkins.ceph.com/job/ceph-pull-requests/165762/consoleFull#1743420907e840cee4-f4a4-4183-81dd-42855615f2c1

Copy link
Contributor

@idryomov idryomov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"run full librbd test suite unconditionally" in the PR title seems a bit misleading as there are still a few instances of SKIP_IF_CRIMSON() scattered around the individual tests.

@idryomov
Copy link
Contributor

idryomov commented Aug 26, 2025

Make check is failing with:

[ RUN      ] TestLibRBD.TestPendingAio

This is known -- this test can trigger a long standing but unfortunately non-trivial use-after-free issue in librbd.

@idryomov
Copy link
Contributor

jenkins test make check

@knrt10 knrt10 changed the title qa/suites/crimson-rados: run full librbd test suite unconditionally qa/suites/crimson-rados: run full librbd test suite Aug 28, 2025
@knrt10
Copy link
Member Author

knrt10 commented Aug 28, 2025

"run full librbd test suite unconditionally" in the PR title seems a bit misleading as there are still a few instances of SKIP_IF_CRIMSON() scattered around the individual tests.

aah missed it. Thanks, updated it

@knrt10
Copy link
Member Author

knrt10 commented Aug 29, 2025

Copy link
Contributor

@Matan-B Matan-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This will largely help uncovering the last unsupported tests cases.

@Matan-B Matan-B merged commit 3468465 into ceph:main Aug 31, 2025
28 of 29 checks passed
@Matan-B Matan-B moved this from Needs QA to Merged (Main) in Crimson Aug 31, 2025
@knrt10 knrt10 deleted the test-crimson-librbd-reenable branch August 31, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Merged (Main)

Development

Successfully merging this pull request may close these issues.

3 participants