src: replace push_back(T{}) with emplace_back() #65227
Merged
Conversation
in ed6b712, we switched from some instances of `push_back(Type{})` patterns to `emplace_back()` to simplify the code and to avoid unnecessary overhead of copy/move constructor calls. but there were still remaining instances of them in `generate_test_instance()` member function implementations. in this change, we switched all of them to be more consistent. Signed-off-by: Kefu Chai <tchaikov@gmail.com>
…ances() in ed6b712, we switched some of them to explicit call of constructor to study some compiling failures, but forgot to revert to the original version after the failures were addressed. in this change, we revert them to the original version to be more consistent. Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Merged
14 tasks
Contributor
Author
|
jenkins test make check arm64 |
1 similar comment
Contributor
Author
|
jenkins test make check arm64 |
ronen-fr
approved these changes
Aug 29, 2025
Contributor
ronen-fr
left a comment
There was a problem hiding this comment.
LGTM
(note: additional teams involved)
adamemerson
approved these changes
Sep 12, 2025
idryomov
approved these changes
Sep 13, 2025
Contributor
idryomov
left a comment
There was a problem hiding this comment.
Ack from the RBD perspective
Contributor
|
pr testing of RGW completed : https://tracker.ceph.com/issues/73015 and got approved by @ivancich |
Member
Contributor
Author
|
@ljflores hi Laura, thank you for the reminder. But the change only touches the code used for generating the corpus for performing encoding tests. These corpus data are only used in our CI pipeline. IIUC, our rados tests performed by teuthology does not exercise or use these corpus. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job Definition