Skip to content

libcephfs: convert ceph errno to host-based errno#65135

Merged
rishabh-d-dave merged 3 commits intoceph:mainfrom
rishabh-d-dave:libcephfs-platform-errno
Oct 8, 2025
Merged

libcephfs: convert ceph errno to host-based errno#65135
rishabh-d-dave merged 3 commits intoceph:mainfrom
rishabh-d-dave:libcephfs-platform-errno

Conversation

@rishabh-d-dave
Copy link
Contributor

@rishabh-d-dave rishabh-d-dave commented Aug 20, 2025

Fixes: https://tracker.ceph.com/issues/72401

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

@rishabh-d-dave rishabh-d-dave requested a review from a team August 20, 2025 05:43
@rishabh-d-dave rishabh-d-dave force-pushed the libcephfs-platform-errno branch from c61a8c7 to 8576fde Compare August 20, 2025 06:00
@rishabh-d-dave rishabh-d-dave requested a review from batrick August 20, 2025 06:02
@rishabh-d-dave rishabh-d-dave force-pushed the libcephfs-platform-errno branch 5 times, most recently from 5e3e738 to 04e2456 Compare August 20, 2025 07:55
@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Aug 20, 2025

jenkins test windows

@rishabh-d-dave rishabh-d-dave force-pushed the libcephfs-platform-errno branch from 04e2456 to fb1cf19 Compare August 20, 2025 16:11
@rishabh-d-dave rishabh-d-dave force-pushed the libcephfs-platform-errno branch 2 times, most recently from 976ce79 to 10072ba Compare September 1, 2025 05:32
@github-actions github-actions bot added the tests label Sep 1, 2025
@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Sep 1, 2025 •
edited
Loading

Tests passed -
https://pulpito.ceph.com/rishabh-2025-08-31_22:01:29-fs:libcephfs-libcephfs-platform-errno-2-testing-default-smithi/
https://pulpito.ceph.com/rishabh-2025-09-01_08:09:55-fs:libcephfs-rishabh-libcephfs-platform-errno-3-testing-default-smithi/

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Sep 1, 2025

jenkins test api

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Sep 1, 2025

jenkins test docs

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Sep 2, 2025

jenkins test api

batrick
batrick requested changes Sep 2, 2025
View reviewed changes
@rishabh-d-dave rishabh-d-dave force-pushed the libcephfs-platform-errno branch 3 times, most recently from 50d81e2 to 35929c8 Compare September 8, 2025 10:05
@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Sep 8, 2025

@batrick Gentle reminder, PTAL. :)

@rishabh-d-dave rishabh-d-dave force-pushed the libcephfs-platform-errno branch from 35929c8 to 1b256b3 Compare September 8, 2025 10:44
batrick
batrick requested changes Sep 8, 2025
View reviewed changes
@rishabh-d-dave rishabh-d-dave force-pushed the libcephfs-platform-errno branch from 1b256b3 to 74a021b Compare September 8, 2025 17:44
@rishabh-d-dave rishabh-d-dave added wip-rishabh-testing Rishabh's testing label and removed needs-qa labels Sep 18, 2025
@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Sep 26, 2025

jenkins test docs

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Sep 29, 2025

This PR is under test in https://tracker.ceph.com/issues/73311.

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Oct 3, 2025

jenkins test docs

2 similar comments
@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Oct 3, 2025

jenkins test docs

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Oct 3, 2025

jenkins test docs

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Oct 3, 2025

jenkins retest this please

@rishabh-d-dave rishabh-d-dave reopened this Oct 3, 2025
@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Oct 3, 2025

jenkins test docs

@rishabh-d-dave
qa: set -x for qa/workunits/libcephfs/test.sh
c9b2336 
LibCephFS unit tests are compiled into different binary files and run
after another but without logging name of the binary being executed,
which can make it bit difficult to find out which binary/test group is
being run. Therefore "set -x" in the script so that binary name/test
group is printed before tests run.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Oct 3, 2025

Rebasing since CI job for docs is failing repeatedly due to unrelated error.

@rishabh-d-dave rishabh-d-dave force-pushed the libcephfs-platform-errno branch from 20e6b95 to b6d24e5 Compare October 3, 2025 14:15
@rishabh-d-dave
src/include: move ceph_to_hostos_errno() to separate header file
2ca8838 
Including src/include/types.h in src/pybind/cephfs/types.pxd leads to
compilation error: "fatal error: acconfig.h: No such file or directory".
types.h as well as int_types.h include acconfig.h header file.

Move the code to be included in types.pxd to a separate file where
acconfig.h won't be included, thus preventing this error.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
@rishabh-d-dave
pybind: convert ceph errno to host-based errno
2439bcb 
Fixes: https://tracker.ceph.com/issues/72401
Signed-off-by: Rishabh Dave <ridave@redhat.com>
@rishabh-d-dave rishabh-d-dave force-pushed the libcephfs-platform-errno branch from b6d24e5 to 2439bcb Compare October 3, 2025 14:25
@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Oct 3, 2025

jenkins test make check

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Oct 3, 2025

jenkins test make check arm64

rishabh-d-dave
rishabh-d-dave commented Oct 3, 2025
View reviewed changes
Copy link
Contributor Author

@rishabh-d-dave rishabh-d-dave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA run was successful - https://tracker.ceph.com/projects/cephfs/wiki/QA_main_2025#wip-rishabh-testing-20250929182116

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Oct 3, 2025

This PR is under test in https://tracker.ceph.com/issues/73357.

rishabh-d-dave
rishabh-d-dave commented Oct 7, 2025
View reviewed changes
Copy link
Contributor Author

@rishabh-d-dave rishabh-d-dave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA run was successful - https://tracker.ceph.com/projects/cephfs/wiki/QA_main_2025#wip-rishabh-testing-20251003161005-debug

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Oct 7, 2025

jenkins test make check

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Oct 7, 2025

jenkins test make check arm64

@rishabh-d-dave rishabh-d-dave merged commit f3d5db4 into ceph:main Oct 8, 2025
13 checks passed
This was referenced Oct 8, 2025
Open
Open
@rishabh-d-dave rishabh-d-dave deleted the libcephfs-platform-errno branch October 8, 2025 03:08
@vshankar vshankar mentioned this pull request Oct 9, 2025
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@batrick batrick batrick approved these changes

Assignees

No one assigned

Labels

cephfs Ceph File System pybind tests wip-rishabh-testing Rishabh's testing label wip-rishabh-testing3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rishabh-d-dave @batrick