mds: fix snapdiff result fragmentation#64995
Conversation
Reproduces: https://tracker.ceph.com/issues/72518 Signed-off-by: Md Mahamudur Rahaman Sajib <mahamudur.sajib@croit.io> (cherry picked from commit 4ff7138)
Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
…ded. This is required when more entries with the same name don't fit into the fragment. With the existing means for fragment offset specification such a splitting to be prohibited. Fixes: https://tracker.ceph.com/issues/72518 Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
c2c9b94 to
24955e6
Compare
|
jenkins test make check |
|
jenkins test make check arm64 |
|
jenkins test make check |
1 similar comment
|
jenkins test make check |
|
@ifed01 https://tracker.ceph.com/issues/72518 says the test passes in main and not in reef. Do we know why? And, this change is for the main branch, so I'm not 100% clear. |
IMO the issue is present in all Ceph releases but starting Squid snapdiff listing is has a bit different fragment boundaries as some entries' encodings have changed. |
In fact reverting 24955e6 and increasing amount of files in LibCephFS.SnapDiffDeletionRecreation:
reproduces the issue in main branch as well. |
Thanks for verifying that. |
vshankar
left a comment
There was a problem hiding this comment.
Nicely implemented @ifed01 @sajibreadd
Good work!
issue. Snapdiff listing fragments have different boundaries in Reef and Squid+ releases hence original reproducer (made for Reef) doesn't work properly in S+ releases. This patch fixes that at cost of longer execution. This might be redundant/senseless when backporting to Reef. Related-to: https://tracker.ceph.com/issues/72518 Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
|
jenkins test api |
|
This PR is under test in https://tracker.ceph.com/issues/72684. |
|
jenkins test api |
|
jenkins test make check arm64 |
Fixes: https://tracker.ceph.com/issues/72518
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job Definition