cephfs: fix monclient not subscribed monmap/config#64909
Conversation
|
jenkins test make check arm64 |
|
@chrisphoffman gentle nudge on this. |
|
@chrisphoffman gentle nudge. |
chrisphoffman
left a comment
There was a problem hiding this comment.
Thank you for your submission. This overall looks good, there's one minor thing to change.
Can you add the below "Fixes:.." to your commit message on the Client change?
Fixes: https://tracker.ceph.com/issues/72493
@darkwsh -- can you please do the needful as above? |
|
This PR is under test in https://tracker.ceph.com/issues/73693. |
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
In SingletonClient::init(), objecter->start() called before monc->authenticate(), it makes conns of monc authencated before monc->authenticate() called if mons reply faster, in this case, monc will not subsribe monmap/config. Signed-off-by: Shaohui Wang <wangshaohui.0512@bytedance.com>
Signed-off-by: Shaohui Wang <wangshaohui.0512@bytedance.com>
16bf73a to
1de46f3
Compare
|
rebased+updated |
StandaloneClient::init makes monclient authenticated
early cause objecter::start called. It will makes monclient
ignore subscribe monmap/config.
The first commit is a unit test for this case,
the second commit is a patch to ensure that monclient
authenticated first.
Fixes: https://tracker.ceph.com/issues/72493
Signed-off-by: Shaohui Wang wangshaohui.0512@bytedance.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job Definition