rgw/s3: support paginated ListBuckets#64742
Conversation
|
test case in ceph/s3-tests#679 |
| s->formatter->close_section(); | ||
| s->formatter->close_section(); // Buckets | ||
| if (!marker.empty()) { | ||
| s->formatter->dump_string("ContinuationToken", marker); |
There was a problem hiding this comment.
note that the aws doc says "ContinuationToken is obfuscated and is not a real bucket."
but we make no effort to obfuscate here, like we don't for ListObjectsV2
There was a problem hiding this comment.
when they say "obfuscated" they probably should mean "opaque"
at some point, aws added pagination support to ListBuckets[1] in the form of query params max-buckets and continuation-token RGWListBuckets already supported pagination for the swift api, so we only need to hook up the s3 request/response formats to use it Fixes: https://tracker.ceph.com/issues/72315 [1] https://docs.aws.amazon.com/AmazonS3/latest/API/API_ListBuckets.html Signed-off-by: Casey Bodley <cbodley@redhat.com>
| s->formatter->close_section(); | ||
| s->formatter->close_section(); // Buckets | ||
| if (!marker.empty()) { | ||
| s->formatter->dump_string("ContinuationToken", marker); |
There was a problem hiding this comment.
when they say "obfuscated" they probably should mean "opaque"
|
qa https://pulpito.ceph.com/cbodley-2025-08-14_20:48:33-rgw-wip-72315-distro-default-smithi/
at least one verify job shows the new test case passing:
|
|
jenkins test api |
|
jenkins test windows |
|
jenkins test make check arm64 |
|
jenkins test api |
1 similar comment
|
jenkins test api |
|
jenkins test make check arm64 |
|
https://jenkins.ceph.com/job/ceph-pull-requests-arm64/79833/
|
|
jenkins test make check arm64 |
at some point, aws added pagination support to ListBuckets in the form of query params
max-bucketsandcontinuation-tokenRGWListBucketsalready supported pagination for the swift api, so we only need to hook up the s3 request/response formats to use itFixes: https://tracker.ceph.com/issues/72315
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job Definition