Skip to content

squid: osd: Access/Modify epoch maps under mutex in OSDSuperblock class#64732

Merged
yuriw merged 1 commit intoceph:squidfrom
mohit84:tick_osd_squid
Oct 24, 2025
Merged

squid: osd: Access/Modify epoch maps under mutex in OSDSuperblock class#64732
yuriw merged 1 commit intoceph:squidfrom
mohit84:tick_osd_squid

Conversation

@mohit84
Copy link
Contributor

@mohit84 mohit84 commented Jul 29, 2025

backport tracker: https://tracker.ceph.com/issues/72070

backport of #62916
parent tracker: https://tracker.ceph.com/issues/66819
(cherry picked from commit 8cf896e)

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

@mohit84 mohit84 requested review from a team as code owners July 29, 2025 08:58
@github-actions github-actions bot added this to the squid milestone Jul 29, 2025
@mohit84 mohit84 requested a review from rzarzynski July 29, 2025 08:59
@mohit84
Copy link
Contributor Author

mohit84 commented Jul 29, 2025

jenkins test make check

@rzarzynski rzarzynski changed the title osd: Access/Modify epoch maps under mutex in OSDSuperblock class squid: osd: Access/Modify epoch maps under mutex in OSDSuperblock class Jul 30, 2025
Copy link
Contributor

@rzarzynski rzarzynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mohit84: thanks for the backport! LGTM apart one but important thing.

The commit misses the mandatory "cherry picked from

" remark. It can be automatically by appending -x while cherry-picking: git cherry-pick -x <main commit ID>.

@pponnuvel
Copy link
Contributor

@mohit84 ping

@mohit84
Copy link
Contributor Author

mohit84 commented Sep 3, 2025

@mohit84: thanks for the backport! LGTM apart one but important thing.

The commit misses the mandatory _"cherry picked from _

" remark. It can be automatically by appending -x while cherry-picking: git cherry-pick -x <main commit ID>.

I have updated message manually, i used backport-create-issue script, i think it does not push a message "cherry picked from commit"

backport tracker: https://tracker.ceph.com/issues/72070

backport of ceph#62916
parent tracker: https://tracker.ceph.com/issues/66819
(cherry picked from commit 8cf896e)

Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
@pponnuvel
Copy link
Contributor

Thanks @mohit84 for the update.

@rzarzynski would you mind taking another look and merge if all looks good? Thanks.

@pponnuvel
Copy link
Contributor

jenkins test make check

@pponnuvel
Copy link
Contributor

jenkins test api

@pponnuvel
Copy link
Contributor

jenkins test docs

@pponnuvel
Copy link
Contributor

Hi @rzarzynski All tests and builds passed. Please take another look. Thanks.

@JonBailey1993
Copy link
Contributor

@yuriw yuriw merged commit fc68dcd into ceph:squid Oct 24, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants