auth: remove unused AuthTicket::renew_after member variable#64591
Merged
auth: remove unused AuthTicket::renew_after member variable#64591
Conversation
Contributor
Author
|
@NitzanMordhai Hi Nitzan, I noticed you implemented the |
Merged
14 tasks
14 tasks
Contributor
Author
|
jenkins test make check |
Contributor
Author
|
jenkins test make check arm64 |
idryomov
reviewed
Jul 21, 2025
The AuthTicket::renew_after field is only set in init_timestamps() and read by dump() for debugging purposes. It has no functional use cases and causes encoding/decoding inconsistencies. During decoding, this field remains unchanged, creating discrepancies between original and decoded values. This issue was masked because check-generated.sh and readable.sh reused struct instances, preserving stale field values across encode/decode cycles. An upcoming change will allocate fresh instances for each decode operation, which would expose these inconsistent values. Remove the unused field to eliminate the encoding inconsistency and simplify the codebase. Signed-off-by: Kefu Chai <tchaikov@gmail.com>
611315e to
928aa98
Compare
Contributor
Author
|
changelog
|
idryomov
approved these changes
Jul 21, 2025
Contributor
Author
|
jenkins test make check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AuthTicket::renew_after field is only set in init_timestamps() and read by dump() for debugging purposes. It has no functional use cases and causes encoding/decoding inconsistencies.
During decoding, this field remains unchanged, creating discrepancies between original and decoded values. This issue was masked because check-generated.sh and readable.sh reused struct instances, preserving stale field values across encode/decode cycles.
An upcoming change will allocate fresh instances for each decode operation, which would expose these inconsistent values.
Remove the unused field to eliminate the encoding inconsistency and simplify the codebase.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job Definition