qa/standalone/scrub: fix "scrubbed in 0ms" in osd-scrub-test.sh#64429
Merged
qa/standalone/scrub: fix "scrubbed in 0ms" in osd-scrub-test.sh#64429
Conversation
The specific test looks for a 'last scrub duration' higher than 0 as a sign that the scrub actually ran. Previous code fixes guaranteed that even a scrub duration as low as 1ms would be reported as "1" (1s). However, none of the 15 objects created in this test were designated for the tested PG, which remained empty. As a result, the scrub duration was reported as "0". The fix is to create a large enough number of objects so that at least one of them is mapped to the tested PG. Fixes: https://tracker.ceph.com/issues/71801 Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
rzarzynski
approved these changes
Jul 10, 2025
Contributor
Author
|
Running the Teuthology test (this change only involves one test) myself now (currently - 4 copies of the test). |
Contributor
Author
|
Merging based on 8X runs of the test in Teuthology |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The specific test looks for a 'last scrub duration' higher than 0 as a sign that the scrub actually ran. Previous code fixes guaranteed that even a scrub duration as low as 1ms would be reported as "1" (1s). However, none of the 15 objects created in this test were designated for the tested PG, which remained empty. As a result, the scrub duration was reported as "0".
The fix is to create a large enough number of objects so that at least one of them is mapped to the tested PG.
Fixes: https://tracker.ceph.com/issues/71801